From 090e1a2c6eb9809f31b76c0e94177f41a9fa3212 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Mon, 23 Jul 2012 11:45:48 +1700 Subject: [PATCH] Re: [PATCH v4 0/8] emacs: JSON-based search cleanups --- 65/4ff4b08dc17c7e02ee245f85e18692ffc0d466 | 106 ++++++++++++++++++++++ 1 file changed, 106 insertions(+) create mode 100644 65/4ff4b08dc17c7e02ee245f85e18692ffc0d466 diff --git a/65/4ff4b08dc17c7e02ee245f85e18692ffc0d466 b/65/4ff4b08dc17c7e02ee245f85e18692ffc0d466 new file mode 100644 index 000000000..ae6515494 --- /dev/null +++ b/65/4ff4b08dc17c7e02ee245f85e18692ffc0d466 @@ -0,0 +1,106 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 45144431FAF + for ; Sun, 22 Jul 2012 11:46:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ST9LQcfNcTW9 for ; + Sun, 22 Jul 2012 11:45:58 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id D0ED5431FAE + for ; Sun, 22 Jul 2012 11:45:58 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 5FF9666E00B8; + Sun, 22 Jul 2012 11:45:58 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.192.57]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 7B93366E00B9; + Sun, 22 Jul 2012 11:45:54 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id D54A05CF; Sun, 22 Jul 2012 11:45:52 -0700 (PDT) +From: Jameson Graef Rollins +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 0/8] emacs: JSON-based search cleanups +In-Reply-To: <1342892232-5659-1-git-send-email-amdragon@mit.edu> +References: <1341354059-29396-1-git-send-email-amdragon@mit.edu> + <1342892232-5659-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.13.2+90~gb97ff6a (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 22 Jul 2012 11:45:48 -0700 +Message-ID: <87fw8j8wir.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 22 Jul 2012 18:46:01 -0000 + +--=-=-= + +On Sat, Jul 21 2012, Austin Clements wrote: +> This version fixes several bugs found in the previous version. I +> replaced the insert-before-markers trick in +> notmuch-search-update-result with direct point manipulation. This +> fixes the problem with authors getting unhidden when a result is +> updated with point after the authors on the line (since it no longer +> deletes the region with the invisibility overlay). I also removed the +> scrolling hack (which was partially necessitated by +> insert-before-markers), so that archiving the last visible result will +> properly scroll the buffer instead of jumping point to the middle of +> the visible window. As a result, the window may scroll when updating +> a multiline result, however, it will scroll to show the entire result +> (unlike an earlier version where it scrolled to cut off the result +> because of an interaction with insert-before-markers). Finally, I +> fixed notmuch-search-last-thread so that it behaves like it did before +> when there are no results, rather than failing with an obscure error. +> +> I also updated the customize documentation and NEWS to indicate that +> multiline search results are considered experimental. + +This seems to fix the minor issues with the previous series, and seems +to be behaving great. The changes and the documentation fixes look good +to me. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQDEpcAAoJEO00zqvie6q89fUP/07h8F2HGBJChU9AAkchzmmG +ciJPtBdohEKJImtrrk/mIQ4m4tUGSVvoODe/I3ITciGjBBTagxaItaSyuWq+x6f+ +MiJjfK0Qjwru8YKybx6jeJgEoZv/NPYvd/3Gm7kTjZAa269tpW5PtXiIzyYVQMIH +7MbDerMAckW9ySxrvjamYr8D2GNX49vYJ0z/Wshjt0yHgb0+vSBjBHEMBF3Rasv/ +MqXKptC5z5WFNMpz89syOQTqlEJKveEgRS3y4UxLiO3D0YVTf05gJ5TBc/lCGaOX +4ggxGm4VuqlI9HiYisRZDso/xmLc3ztwoM0JfrflSvwCyQq7/3Ql30G36d05UKKZ +jLBX8hVwl4xV+RTq3woWUaHMH33SYHWmDybdzI3vA1azXcuVi9a875llcO2YbLB0 +IFw8q6WkX9KP/iAlxL7DCb3NPDpyA2ryYPZLQsNLNBU4/rphTVZGAzF4x9l/QUM/ +U/celaS+ycQP7Eh9KvIK2UF1FPJpI+vjbJNtG1SodAzEvkMhXz2wK2iZM9jpnky7 +2X38C0VcDAGiKEr9GQCCNalSMhFE9ZcLdIjKAovN8fgUhjsYfWj0Z9FIzsJ1PBmo +br+4J3WBaZ3JwCBxw6PP+rvIXoGWt/tsxV96TBOqjO8/wziJkUBV6cV/tQ0tCvy9 +HS6Egvlsypbmwk/OScUG +=x9V7 +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2