From 084f2aecff7bc200c6dc9c4803469849e4e2147c Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Wed, 22 Feb 2012 09:49:37 +1700 Subject: [PATCH] Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and message-cite-original --- 96/88f8cdad80705a5a29047c498c2ded18c6aca9 | 115 ++++++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 96/88f8cdad80705a5a29047c498c2ded18c6aca9 diff --git a/96/88f8cdad80705a5a29047c498c2ded18c6aca9 b/96/88f8cdad80705a5a29047c498c2ded18c6aca9 new file mode 100644 index 000000000..c9aac261b --- /dev/null +++ b/96/88f8cdad80705a5a29047c498c2ded18c6aca9 @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4EC95431FAF + for ; Tue, 21 Feb 2012 08:49:44 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yzekFmOyaLJc for ; + Tue, 21 Feb 2012 08:49:40 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2CAA5431FAE + for ; Tue, 21 Feb 2012 08:49:40 -0800 (PST) +Received: by lahd3 with SMTP id d3so8197774lah.26 + for ; Tue, 21 Feb 2012 08:49:37 -0800 (PST) +Received-SPF: pass (google.com: domain of awg@xvx.ca designates 10.152.132.104 + as permitted sender) client-ip=10.152.132.104; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of awg@xvx.ca designates + 10.152.132.104 as permitted sender) smtp.mail=awg@xvx.ca +Received: from mr.google.com ([10.152.132.104]) + by 10.152.132.104 with SMTP id ot8mr19916214lab.17.1329842977288 + (num_hops = 1); Tue, 21 Feb 2012 08:49:37 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.152.132.104 with SMTP id ot8mr16667867lab.17.1329842977230; + Tue, 21 Feb 2012 08:49:37 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.112.114.103 with HTTP; Tue, 21 Feb 2012 08:49:37 -0800 (PST) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <20120221055920.GA30513@mit.edu> +References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca> + <1329361957-28493-8-git-send-email-awg+notmuch@xvx.ca> + <20120221055920.GA30513@mit.edu> +Date: Tue, 21 Feb 2012 09:49:37 -0700 +X-Google-Sender-Auth: ERr9P2lj7sKIQgkocaxdaqzQvxE +Message-ID: + +Subject: Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and + message-cite-original +From: Adam Wolfe Gordon +To: Austin Clements +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQl5Ip+NRI6RQ/VODut1+trih2+UdbG+/lW7acaaHCJAbqy+VxjEB0+vXt/GE4uI/YXFpRzL +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 21 Feb 2012 16:49:44 -0000 + +On Mon, Feb 20, 2012 at 22:59, Austin Clements wrote: +> I've been thinking about this more. =A0message-mode's default citation +> line is really unfortunate and quite possibly insane ("writes" isn't +> even the right tense and what's up with that extra line break?). =A0The +> option to change this is also well hidden (as an experiment, I tried +> navigating to it through customize and couldn't figure out where it +> was, even though I knew what I was looking for). =A0In general, I'm a +> fan of inheriting as many options from Emacs as possible, but people +> *are* going to ask how to change this and the default setting *is* +> going to turn people off of notmuch ("What mail client do you use that +> generates those quirky citation lines?" =A0"I use notmuch!" =A0"Is that, +> like, from the 80's?"). + +Agreed. It's a really unfortunate default. + +> So, what about adding a notmuch customize option for selecting the +> citation line format? =A0It could offer a few const choices, including a +> default, sane format, plus the option to enter your own or to fall +> back to whatever message-mode is configured to do. =A0If we do this, +> it's probably best done in a follow-up series, but this seemed like an +> appropriate place to bring it up. + +I think there are two options, which have been discussed a bit before [1]: + +1) Wrap the citation format with a notmuch customization variable, +notmuch-citation-line-format or somesuch. Then set the +message-citation-line-format before calling message-cite-original. + +2) Have notmuch load a user config file (~/.notmuch.el or something) +on startup, and provide a default file that sets nice defaults for +things like message-citation-line-format. The default file could even +be constructed on first run, such that if the user has already +customized some things (like message-citation-line-format) we can keep +their settings. + +Option 2 is obviously more work, but I think it's the right way to go, +at least in the long run. In addition to giving a place to provide +nice defaults for non-notmuch variables, it gives the user a nice +place to specify notmuch-specific config. For example, I use +completely separate init files for notmuch and other emacs usage, and +having a notmuch config file would let me get away from this slightly +kludgey setup. + +In either case, this can probably come as a separate patch series, but +it is good to start discussing it here. + +[1] id:"m2mx9i3onw.fsf@wal122.wireless-pennnet.upenn.edu" -- 2.26.2