From 0676676decc61496cfe1004881af8660ae1460f6 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sat, 14 Jul 2012 13:37:18 +1700 Subject: [PATCH] Re: [PATCH 2/3] cli: show allow the caller to specify the headers output. --- b6/fbe8ed0949e5ba2a1c391e4903d08ec9b8ebb0 | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 b6/fbe8ed0949e5ba2a1c391e4903d08ec9b8ebb0 diff --git a/b6/fbe8ed0949e5ba2a1c391e4903d08ec9b8ebb0 b/b6/fbe8ed0949e5ba2a1c391e4903d08ec9b8ebb0 new file mode 100644 index 000000000..eeac08b2a --- /dev/null +++ b/b6/fbe8ed0949e5ba2a1c391e4903d08ec9b8ebb0 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6247A431FB6 + for ; Fri, 13 Jul 2012 13:37:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NepEl-wBKH3u for ; + Fri, 13 Jul 2012 13:37:28 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 4C34B431FAE + for ; Fri, 13 Jul 2012 13:37:28 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id C970266E018E; + Fri, 13 Jul 2012 13:37:27 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (DHCP-123-184.caltech.edu [131.215.123.184]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id D7B5E66E0137; + Fri, 13 Jul 2012 13:37:20 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 8D4953CA; Fri, 13 Jul 2012 13:37:20 -0700 (PDT) +From: Jameson Graef Rollins +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/3] cli: show allow the caller to specify the headers + output. +In-Reply-To: <87bojjcuey.fsf@qmul.ac.uk> +References: <1341673978-6094-1-git-send-email-markwalters1009@gmail.com> + <1341673978-6094-3-git-send-email-markwalters1009@gmail.com> + <878venxxpe.fsf@servo.finestructure.net> + <87bojjcuey.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.13.2+82~gd0a8b58 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 13 Jul 2012 13:37:18 -0700 +Message-ID: <877gu7gzy9.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 13 Jul 2012 20:37:32 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +On Fri, Jul 13 2012, Mark Walters wrote: +> I basically agree but it looked like it would be relatively ugly to pass +> around.=20 +> +> However, perhaps this is all being too general: the caller probably +> cares that all the headers it wants are output and perhaps not too many +> others (eg over ssh or to android etc). Would something more like +> headers=3Dbrief or headers=3Dfull be enough? And we would still want an +> option allowing the body to be omitted. +> +> What do you think? + +I think different people are going to want different headers, and I know +that people want headers that are not included in the default output. +It just seems to me we would be better served with a more general +solution. Just being able to specify from the headers we are already +outputting doesn't seem like much of an improvement to me. + +As for body omission: I still think it would be a nice clean separation +if the contents of body parts were retrieved separately. If there +really are situations where that constitutes a performance hit, I guess +we'll want the option. Although I would argue that bodies should be +omitted by default, and the option should include them, rather than +vice-versa. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQAIb+AAoJEO00zqvie6q8iIIP/juIWMUbS90wz1IXFH7DF+lV +KleuCkLcHlm1qwyXMLQJC8kKkwLeMA206c4gbG/Ts+2XyzVyjRSgoZizIZm9sNPE +x2/YDXfkJNwjQDzV/4e/Rmx9meHtCAfxIDNoxByPLL3OpgRF8LeaFtRd5OT7V+aN +AQfswq8SoO/Me19zMj5vrb2w9JC4M0l7Pzx3k3B9NRm8kyrEELEFqIYJMGu9s2MS +8MVEqwuZ0ogI1mWXetWDV2GbvqLUKLTWzvVle61XARLCfcODcV4GwQXfSHLX3Tmj +wdolwgiELctRy4sjLmCiEI2LGROnCiAhVwQFX2uq6wg0khswOZvoYdi6daxKmqO1 +oW9+8sG39pNZb57PiRY1gf/LgDfUTyGxAPktadCDzkxqMl6NTGXiaoMbl6/kYAOn +MlT3g3VIoe1Cx+QJdEocMe0RB/4dJ5X7fVwotFy2hrW1JYi1hsseB5wNCJZf9Zpr +6hBbuYvaEEHCxwqJ8uSuJOOpTY4cxWT6nC8kPT4DuPKAllTaklMgpCxNGQSRuTV3 +kbbX3EfdtJxHsFxMwCO2YG7CVfiuSI38jnj0VZ4zA2UqMEw2sXDWAsDXmm+czZqN +bYXg+N9NGi5EFHfZbhM2Ohj7st49i2QNgKNtOt2PqS+W6bDnYTA8s59YujCt9Oc8 +Na06n2hmexlQuw6Ncb6H +=/fq7 +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2