From 0580ed4c80bf4e8cf12bc47fb725ed78f043722d Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 10 Jan 2013 06:26:54 +0200
Subject: [PATCH] Re: [PATCH] cli: bail out and propagate tagging errors in
 notmuch tag

---
 6b/c16c9a254d122c4015e738f3396e84f71aa86b | 73 +++++++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644 6b/c16c9a254d122c4015e738f3396e84f71aa86b

diff --git a/6b/c16c9a254d122c4015e738f3396e84f71aa86b b/6b/c16c9a254d122c4015e738f3396e84f71aa86b
new file mode 100644
index 000000000..16b0d7594
--- /dev/null
+++ b/6b/c16c9a254d122c4015e738f3396e84f71aa86b
@@ -0,0 +1,73 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id C0C36431FB6
+	for <notmuch@notmuchmail.org>; Wed,  9 Jan 2013 20:27:04 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id HgR7NgosdwGL for <notmuch@notmuchmail.org>;
+	Wed,  9 Jan 2013 20:27:04 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id D4E76431FAF
+	for <notmuch@notmuchmail.org>; Wed,  9 Jan 2013 20:27:03 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id C8A5F1000D0;
+	Thu, 10 Jan 2013 06:26:54 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
+	notmuch@notmuchmail.org
+Subject: Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag
+In-Reply-To: <87fw29wwzp.fsf@zancas.localnet>
+References: <1357681314-29384-1-git-send-email-jani@nikula.org>
+	<87fw29wwzp.fsf@zancas.localnet>
+User-Agent: Notmuch/0.14+259~g287394f (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 10 Jan 2013 06:26:54 +0200
+Message-ID: <m2txqphddd.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 10 Jan 2013 04:27:04 -0000
+
+On Thu, Jan 10 2013, David Bremner <david@tethera.net> wrote:
+
+> Jani Nikula <jani@nikula.org> writes:
+>> +	if (ret)
+>> +	    break;
+>
+> I amended this to (ret != NOTMUCH_STATUS_SUCCESS) 
+>
+> There are a few different families of status codes flying around here,
+> and I liked the extra documentation.
+
+That sure is a good point, should follow-up patch do this:
+
+-    int ret = 0;
++    int ret = NOTMUCH_STATUS_SUCCESS;
+
+?
+
+> d
+
+Tomi
-- 
2.26.2