From 047de21f9def895b1b211fe795530e83c479aa8d Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 26 Apr 2012 09:34:57 +2000 Subject: [PATCH] Re: [PATCH 1/7] Split notmuch_database_close into two functions --- 24/d3c0ba8fee1956667a6768835393bdc870d78d | 95 +++++++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 24/d3c0ba8fee1956667a6768835393bdc870d78d diff --git a/24/d3c0ba8fee1956667a6768835393bdc870d78d b/24/d3c0ba8fee1956667a6768835393bdc870d78d new file mode 100644 index 000000000..f91845cd3 --- /dev/null +++ b/24/d3c0ba8fee1956667a6768835393bdc870d78d @@ -0,0 +1,95 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 42759431FAF + for ; Wed, 25 Apr 2012 06:35:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nqG3oMKmEGR5 for ; + Wed, 25 Apr 2012 06:35:02 -0700 (PDT) +Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU + [18.9.25.14]) + by olra.theworths.org (Postfix) with ESMTP id C22C0431FAE + for ; Wed, 25 Apr 2012 06:35:02 -0700 (PDT) +X-AuditID: 1209190e-b7f7c6d0000008c3-5a-4f97fd859577 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP + id 61.79.02243.58DF79F4; Wed, 25 Apr 2012 09:35:01 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q3PDZ0W9032751; + Wed, 25 Apr 2012 09:35:00 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3PDYvBh007920 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 25 Apr 2012 09:34:59 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SN2Mz-0001e4-Nx; Wed, 25 Apr 2012 09:34:57 -0400 +From: Austin Clements +To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org +Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions +In-Reply-To: + <1335360016-20289-1-git-send-email-4winter@informatik.uni-hamburg.de> +References: <20120422180159.GG17810@mit.edu> + <1335360016-20289-1-git-send-email-4winter@informatik.uni-hamburg.de> +User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1 + (i486-pc-linux-gnu) +Date: Wed, 25 Apr 2012 09:34:57 -0400 +Message-ID: <87r4vcgcji.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUixG6notv6d7q/wfwueYvZrT+YLK7fnMns + wOQx8fxpNo9nq24xBzBFcdmkpOZklqUW6dslcGWcbf3EXPCXtWLtjY9MDYz/WboYOTkkBEwk + 3px9zQhhi0lcuLeerYuRi0NIYB+jxPf+NVDOBkaJbfu/M0E4J5kkfl9qYoFwljBKLJu7lw2k + n01AA6hqOdgsEQE/iVcP5zCB2MICHhI7ru0Bi3MKBEnMOfMFzBYSKJKYvvoemC0qEC/xp3cz + 0BwODhYBVYmVqwJAwrxA5x3ZsIsFwhaUODnzCZjNLKAlcePfS6YJjAKzkKRmIUktYGRaxSib + klulm5uYmVOcmqxbnJyYl5dapGusl5tZopeaUrqJERSSnJJ8Oxi/HlQ6xCjAwajEwzt77zR/ + IdbEsuLK3EOMkhxMSqK8h39N9xfiS8pPqcxILM6ILyrNSS0+xCjBwawkwvviJVCONyWxsiq1 + KB8mJc3BoiTOq6b1zk9IID2xJDU7NbUgtQgmK8PBoSTByw8yVLAoNT21Ii0zpwQhzcTBCTKc + B2j4UpAa3uKCxNzizHSI/ClGRSlx3pKfQAkBkERGaR5cLyxlvGIUB3pFmNcOpIoHmG7gul8B + DWYCGvwtaBrI4JJEhJRUA+OqIF72+Xu+vHnO/GUq+7UepfMX1dvDzZaZidn1R7bODF21dKXS + J/9zbEy7hRWvbYxsXLY32XsSc5iWRr7naY3yxqUlHX07niw2PL/pBUfysgO3nHb1a0ZFVXoK + BpwMvzrd/1+9hrKTxd20qXEZiS+z5iVdqPp8IehNhGTt1HmXNz+v93JndlZiKc5INNRiLipO + BADU44xF9AIAAA== +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 25 Apr 2012 13:35:04 -0000 + +LGTM. + +On Wed, 25 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote: +> Formerly notmuch_database_close closed the xapian database and +> destroyed the talloc structure associated with the notmuch database +> object. Split notmuch_database_close into notmuch_database_close and +> notmuch_database_destroy. +> +> This makes it possible for long running programs to close the xapian +> database and thus release the lock associated with it without +> destroying the data structures obtained from it. +> +> This also makes the api more consistent since every other data +> structure has a destructor function. +> +> The comments in notmuch.h are a courtesy of Austin Clements. +> +> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de> -- 2.26.2