From 03c3d16cf3c53459657d5f94bc439c374a6e72c7 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Mon, 23 Jul 2012 17:17:17 +0100 Subject: [PATCH] [PATCH 0/4] Add a --body option to notmuch show --- 83/8c9ec122457aff4e97b784862ed844acbd4015 | 100 ++++++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 83/8c9ec122457aff4e97b784862ed844acbd4015 diff --git a/83/8c9ec122457aff4e97b784862ed844acbd4015 b/83/8c9ec122457aff4e97b784862ed844acbd4015 new file mode 100644 index 000000000..250c49a77 --- /dev/null +++ b/83/8c9ec122457aff4e97b784862ed844acbd4015 @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C7545431FB6 + for ; Mon, 23 Jul 2012 09:17:26 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 54rpcgVxixXQ for ; + Mon, 23 Jul 2012 09:17:26 -0700 (PDT) +Received: from mail-we0-f181.google.com (mail-we0-f181.google.com + [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3881D431FAF + for ; Mon, 23 Jul 2012 09:17:26 -0700 (PDT) +Received: by weyt57 with SMTP id t57so4914893wey.26 + for ; Mon, 23 Jul 2012 09:17:24 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer; + bh=dNHORNfL0Yi296IGTjV3NVuQF6vrTbnvMepeNEGArL8=; + b=AByWMY/Rui8DdYMTde5QC+H4tjbwAbUIALWWss/1R5NPRm8uMEa/ZpWj3KDBrf8V7z + 7+W22UVrPXysV2Q8pDrAnk9GcPdeJ/6kE+R+v9Dx6TumKaLYAVxnWN36OKUh9wIUwBQS + 9ZL1+r3yQl6/1Vqlfsx+OUt9ZbJXhglqy9CRfZu78N6WCTKnHNd7F3ryT+1G8jrPXsrw + WKwi7dL+KmMjku+aAE3JcewiOhselxG5XQPeZ0XW0wIczSdT5VkwmA1eg85dRYWJLw06 + cFiD1Vviu59NY8fHwwrjYOYYEoL+OSfXjhgE7CBSq8gpWyH/PHNr65aVJI7gz0i2KeuX + PtAg== +Received: by 10.216.209.8 with SMTP id r8mr8891242weo.51.1343060244781; + Mon, 23 Jul 2012 09:17:24 -0700 (PDT) +Received: from localhost (94-192-233-223.zone6.bethere.co.uk. + [94.192.233.223]) by mx.google.com with ESMTPS id + el6sm17605393wib.8.2012.07.23.09.17.22 (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 23 Jul 2012 09:17:23 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/4] Add a --body option to notmuch show +Date: Mon, 23 Jul 2012 17:17:17 +0100 +Message-Id: <1343060241-18283-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 23 Jul 2012 16:17:27 -0000 + +After discussion on irc today here is another version of the omit body +patches. The conclusion on irc was that the option should just make +the body: field in the JSON output optional. The --body=false option +omits this field. The default remains --body=true including the body: +field in the output. + +This version includes tests for the new functionality and updates the +manpage and the schemata. + +The motivation for this patch is that some callers do not need the +body and omitting it gives a substantial speed up and substantial +reduction in amount of data output. + +Previous related patches are at +id:"1342967879-20453-1-git-send-email-markwalters1009@gmail.com" and +id:"1341041595-5858-1-git-send-email-markwalters1009@gmail.com" + +Best wishes + +Mark + + + +Mark Walters (4): + cli: add --body=true|false option to notmuch-show.c + test: add tests for the new --body=true|false option + man: update man page for the new --body=true|false option + schemata: update for --body=true|false option + + devel/schemata | 2 +- + man/man1/notmuch-show.1 | 16 ++++++++++++++++ + notmuch-client.h | 3 ++- + notmuch-reply.c | 2 +- + notmuch-show.c | 23 +++++++++++++++-------- + test/json | 9 +++++++++ + 6 files changed, 44 insertions(+), 11 deletions(-) + +-- +1.7.9.1 + -- 2.26.2