From 034c62d1336462f5220bd6f5aa052449ac6120e5 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Fri, 10 Aug 2012 00:54:55 +1700 Subject: [PATCH] Re: [PATCH] emacs: Fix "not defined at runtime" warning --- c0/5ce16800532767a791c604cfffb420c9daeefc | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 c0/5ce16800532767a791c604cfffb420c9daeefc diff --git a/c0/5ce16800532767a791c604cfffb420c9daeefc b/c0/5ce16800532767a791c604cfffb420c9daeefc new file mode 100644 index 000000000..4a4991231 --- /dev/null +++ b/c0/5ce16800532767a791c604cfffb420c9daeefc @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4C252431FAF + for ; Thu, 9 Aug 2012 00:55:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3VwNPTi3SDBp for ; + Thu, 9 Aug 2012 00:55:03 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id C88F5431FAE + for ; Thu, 9 Aug 2012 00:55:03 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 60EC766E0123; + Thu, 9 Aug 2012 00:55:01 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.192.57]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 4C8E666E0121; + Thu, 9 Aug 2012 00:54:58 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id DD46A73E; Thu, 9 Aug 2012 00:54:57 -0700 (PDT) +From: Jameson Graef Rollins +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Fix "not defined at runtime" warning +In-Reply-To: <1344462010-5349-1-git-send-email-amdragon@mit.edu> +References: <1344462010-5349-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.13.2+137~ge34ed71 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 09 Aug 2012 00:54:55 -0700 +Message-ID: <87628sa4a8.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 09 Aug 2012 07:55:04 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +On Wed, Aug 08 2012, Austin Clements wrote: +> Previously, the Emacs byte compiler produced the warning +> +> the function `remove-if-not' might not be defined at runtime. +> +> because we only required cl at compile-time (not runtime). This fixes +> this warning by requiring cl at runtime, ensuring that the definition +> of remove-if-not is available. +> --- +> emacs/notmuch-lib.el | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el +> index 30db58f..900235b 100644 +> --- a/emacs/notmuch-lib.el +> +++ b/emacs/notmuch-lib.el +> @@ -24,7 +24,7 @@ +> (require 'mm-view) +> (require 'mm-decode) +> (require 'json) +> -(eval-when-compile (require 'cl)) +> +(require 'cl) +>=20=20 +> (defvar notmuch-command "notmuch" +> "Command to run the notmuch binary.") + +LGTM. I think it would be good to finally just give in a require cl, so +we can finally put to rest the long standing schizophrenia we've had in +regards to using it, and maybe finally kill the compile warnings that +keep popping up. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQI2zPAAoJEO00zqvie6q8WvsP/03xPiW6ed/n232244uU5LkZ +K1+N0Iz7VvcwCp/3IL/gbYW7iQTg0hxLcfcRIBzVvY/eHM6ejB7FQjzzUSLqBL49 +qzepIvXuxC+EbIi5gINhNh51ATbV26243d09a+ulVyO7sBjyqUNA5yGCworjyLBX +a5uE2cLZe6LbcbVTooXiZqOLo5o0rvzxJoxCCfk4qCm1v5DYnl7kkKa6zmqdESrx +3vb+sVoU+VBVjIdeCmw6PzYXlM/Aq0MfWuNOxkk9XxNEDuJJeKHGJK99/A7yL/vP +gsgxwionPySlpT2Kg7lx5VHNUP9tIAR/O2CWkxF937ku4j1PuT/tUl/LNjaqp8py +Y7Td/KEGwaY41MxoWV8LiKFOghrkYCwwp2bc0LqzJbzGidpD56I0FAGZkKtkISsh +T6lEYAk5V1yHMptkutNB7moVD/xGa8GO4V8wsE9EjNMoFtZZ9BZLQXszH//U2A2K +7YMWF9+Ora94D5Tj09c//S8LLCnjWOLJRCm7N4Re4VLioZI43eW+98P19fvABQSQ +7G0NjZygBnjwUrwOGxXRpQsEcDzg8OxFqGX/adC+Wx26EdA2supvRorK5k0lejRp +IJ18fwBH/AZ8kE+sEcKN+OX91qGWro49ISF5aAdNgAoHW/xD0yqjpYjcDlG8O88e +u/CAoEDeVFtUwUu9VLXh +=ZVfl +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2