From 019bdb15e0ffcdd9bc885ffcae199ae52b2070df Mon Sep 17 00:00:00 2001 From: Felipe Contreras Date: Wed, 18 Apr 2012 18:45:04 +0300 Subject: [PATCH] Re: [PATCH v2 1/3] Add 'compose' command --- 24/903fe990cbbc5a394e082b7c55ec5a839ee526 | 133 ++++++++++++++++++++++ 1 file changed, 133 insertions(+) create mode 100644 24/903fe990cbbc5a394e082b7c55ec5a839ee526 diff --git a/24/903fe990cbbc5a394e082b7c55ec5a839ee526 b/24/903fe990cbbc5a394e082b7c55ec5a839ee526 new file mode 100644 index 000000000..aa7c542a3 --- /dev/null +++ b/24/903fe990cbbc5a394e082b7c55ec5a839ee526 @@ -0,0 +1,133 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A2331431FB6 + for ; Wed, 18 Apr 2012 08:45:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pM4bhIldMjgt for ; + Wed, 18 Apr 2012 08:45:05 -0700 (PDT) +Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com + [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 57AE8431FAE for ; Wed, 18 Apr 2012 08:45:05 -0700 + (PDT) +Received: by eekb47 with SMTP id b47so3113290eek.26 + for ; Wed, 18 Apr 2012 08:45:04 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type:content-transfer-encoding; + bh=N554NSK/iRji+IkYyXR1nrlRCeaOkb2zm7hLsI2ZQKI=; + b=v77NFrGqYnzA7wXOhvWoeBOEOjBqjV1jfyb5D1ndf/H4RA805HqRQdbxxyyRDqvKvn + eMkPaEwB0uxTZ1JTZGGIPZEVdRQGKdCOapKvTnxTyoGqyH4ZsOZCaxUvk8r+KyBtKAEx + QR7UHSp07CrBQdouR0LUEWW1rDlvc7exsUd6qtWlwQomCDS2CytNfCXZSv+mNhI6I6+J + pkZbtVnsfWFv/5o0OqLIBCz6xPvJMESgrlRX+f3vcjz9htfVO+OtaWGnfQP584qAIhvn + OFWu7jUQt/OFv2hgP9/Gogdrhkx7aLjsAfqtTbOuSEzoUwUJeSvgELaIosNApeFYI4s2 + YXdQ== +MIME-Version: 1.0 +Received: by 10.213.6.195 with SMTP id a3mr258771eba.78.1334763904109; Wed, 18 + Apr 2012 08:45:04 -0700 (PDT) +Received: by 10.213.19.67 with HTTP; Wed, 18 Apr 2012 08:45:04 -0700 (PDT) +In-Reply-To: <871unlm79r.fsf@gmail.com> +References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com> + <1334752753-23970-2-git-send-email-felipe.contreras@gmail.com> + <873981chpj.fsf@nikula.org> + + <874nshm9yo.fsf@gmail.com> + + <871unlm79r.fsf@gmail.com> +Date: Wed, 18 Apr 2012 18:45:04 +0300 +Message-ID: + +Subject: Re: [PATCH v2 1/3] Add 'compose' command +From: Felipe Contreras +To: Dmitry Kurochkin +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 18 Apr 2012 15:45:09 -0000 + +On Wed, Apr 18, 2012 at 5:41 PM, Dmitry Kurochkin + wrote: +> Felipe Contreras writes: +> +>> On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin +>> wrote: +>>> Hi Felipe. +>>> +>>> Felipe Contreras writes: +>>> +>>>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula wrote: +>>>> +>>>>> Running "notmuch compose" more than once within a second would result= + in +>>>>> identical message ids for the messages, which is not a good idea. Tha= +t's +>>>>> not likely in interactive use, but the notmuch cli is highly scriptab= +le, +>>>>> so someone is bound to hit this. +>>>>> +>>>>> Some paranoid might also be worried about "leaking" the time you run +>>>>> "notmuch compose"... which may be different from the actual time you +>>>>> send the message. +>>>> +>>>> It's still better than the current situation; nothing. In any case, +>>>> people that have not needed this would not be affected; their UI would +>>>> override the Message-ID. +>>>> +>>> +>>> I disagree. =C2=A0If notmuch CLI generates a Message-ID, it must be a g= +ood +>>> one. =C2=A0Otherwise we make users falsely believe that they do have a = +proper +>>> Message-ID while in fact they do not. =C2=A0And that would bite them so= +oner +>>> or later. +>> +>> And then they'll report it, and we would fix it. +>> +>> Anyway, everything comes from a patch, so, do you have a patch, +>> pseudo-code, or even a suggestion? +>> +> +> A patch needs some positive reviews to be accepted. =C2=A0Replying to +> comments with "make a better patch" may not be the best strategy for +> getting your patches accepted. + +I did not say "make a better patch" or anything of the sort. You made +comments, I replied to those comments. + +Your argument is essentially: + +a) we don't have feature X +b) this patch applies feature X imperfectly +c) I don't know how to implement X perfectly + +I don't think "patch is not perfect" is a valid argument. No patch is +perfect, if you want a better patch, then *at least* you should +suggest what would make it better. + +Cheers. + +--=20 +Felipe Contreras -- 2.26.2