From: David Bremner <david@tethera.net>
Date: Tue, 25 Dec 2012 14:18:42 +0000 (+2000)
Subject: Re: [PATCH 2/5] util: Function to parse boolean term queries
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ffe51421756d0acfc13791f6b0fd1411e364f12b;p=notmuch-archives.git

Re: [PATCH 2/5] util: Function to parse boolean term queries
---

diff --git a/a9/1cfdede9b8d338df2459891508385405d24cbf b/a9/1cfdede9b8d338df2459891508385405d24cbf
new file mode 100644
index 000000000..2e1c31d92
--- /dev/null
+++ b/a9/1cfdede9b8d338df2459891508385405d24cbf
@@ -0,0 +1,91 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 147FC431FB6
+	for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 06:18:55 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 09aiYtFh9S1e for <notmuch@notmuchmail.org>;
+	Tue, 25 Dec 2012 06:18:54 -0800 (PST)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 9299D431FAE
+	for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 06:18:54 -0800 (PST)
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.82.78] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
+	(envelope-from <bremner@unb.ca>)
+	id 1TnVLG-0001UQ-Hv; Tue, 25 Dec 2012 10:18:50 -0400
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1TnVL8-00067A-NO; Tue, 25 Dec 2012 10:18:42 -0400
+From: David Bremner <david@tethera.net>
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 2/5] util: Function to parse boolean term queries
+In-Reply-To: <1356415076-5692-3-git-send-email-amdragon@mit.edu>
+References: <1356415076-5692-1-git-send-email-amdragon@mit.edu>
+	<1356415076-5692-3-git-send-email-amdragon@mit.edu>
+User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-pc-linux-gnu)
+Date: Tue, 25 Dec 2012 10:18:42 -0400
+Message-ID: <87obhidxkt.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 25 Dec 2012 14:18:55 -0000
+
+Austin Clements <amdragon@MIT.EDU> writes:
+
+> +    if (consume_double_quote (&pos)) {
+> +	char *out = talloc_strdup (ctx, pos);
+> +	pos = *term_out = out;
+> +	while (1) {
+
+Overall the control flow here is a bit tricky to follow. I'm not sure if
+a real loop condition would help or make it worse.
+
+> +	    if (! *pos) {
+> +		/* Premature end of string */
+> +		goto FAIL;
+> +	    } else if (*pos == '"') {
+> +		if (*++pos != '"')
+> +		    break;
+> +	    } else if (consume_double_quote (&pos)) {
+> +		break;
+> +	    }
+
+I'm confused by the asymmetry here. Quoted strings can start with
+unicode quotes, but internally can only have ascii '"'? Is this
+documented somewhere?
+
+> +    } else {
+> +	while (*pos > ' ' && *pos != ')')
+> +	    ++pos;
+> +	if (*pos)
+> +	    goto FAIL;
+> +    }
+
+So if there is no quote, we skip the part after the ':'? I guess I
+probably missed something because that doesn't sound like the intended
+behaviour.