From: Dmitry Kurochkin Date: Mon, 30 Jan 2012 05:21:41 +0000 (+0400) Subject: Re: [PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=fbfa2f626377de8acbd2d23b31ac68044751214c;p=notmuch-archives.git Re: [PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all' --- diff --git a/cc/0faf9dc793e5ba8680f4ff8b48eccd447751af b/cc/0faf9dc793e5ba8680f4ff8b48eccd447751af new file mode 100644 index 000000000..fdfbf1aad --- /dev/null +++ b/cc/0faf9dc793e5ba8680f4ff8b48eccd447751af @@ -0,0 +1,149 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 53CED431E64 + for ; Sun, 29 Jan 2012 21:22:55 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id S0Xcbictfg1Q for ; + Sun, 29 Jan 2012 21:22:53 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3C771431FBC + for ; Sun, 29 Jan 2012 21:22:53 -0800 (PST) +Received: by bke11 with SMTP id 11so1045813bke.26 + for ; Sun, 29 Jan 2012 21:22:51 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=f8HD7ydswyGifemh4ENI5qa0V0qM3Rx8256Jh77K0NE=; + b=xxHesFgACoLFQiGl7QjQILHMG8vQ33dz7Ce2JA0i9VqTLIAoUqWwY1S5PH5s7jaYAO + /HUVkCzQEP6zq4fihYxcacDaZy+WiD8LVqxIZbHw/VZjSyZwZi8uuCY7UnGC8Q7SxsAF + joWKCXKW3qZCbvuQAU8wVpuU3QEuiM/7Tj62U= +Received: by 10.204.143.131 with SMTP id v3mr7916178bku.83.1327900971776; + Sun, 29 Jan 2012 21:22:51 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id bw9sm35098339bkb.8.2012.01.29.21.22.50 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 29 Jan 2012 21:22:51 -0800 (PST) +From: Dmitry Kurochkin +To: Austin Clements +Subject: Re: [PATCH v2 10/13] emacs: use message ids instead of thread id in + `notmuch-show-operate-all' +In-Reply-To: <20120130045709.GN17991@mit.edu> +References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> + <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com> + <1327890382-548-11-git-send-email-dmitry.kurochkin@gmail.com> + <20120130045709.GN17991@mit.edu> +User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 30 Jan 2012 09:21:41 +0400 +Message-ID: <87k44922ai.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 05:22:55 -0000 + +On Sun, 29 Jan 2012 23:57:09 -0500, Austin Clements wrote: +> Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: +> > Before the change, `notmuch-show-operate-all' used thread id for +> +> notmuch-show-tag-all? +> + +ouch + +> > "notmuch tag" search. This could result in tagging unexpected +> > messages that were added to the thread after the notmuch-show buffer +> > was created. The patch changes `notmuch-show-operate-all' to use ids +> > of shown messages to fix this. +> > --- +> +> If you move this patch before the one that introduces +> notmuch-show-tag-all, you could do it this way from the beginning. +> + +This patch can not be moved before the one that introduces +`notmuch-show-tag-all', because it changes `notmuch-show-tag-all'. +Perhaps you meant to factor out `notmuch-show-mapc' and +`notmuch-show-get-messages-ids-search' into a separate patch(es), but I +am too lazy. + +I merged this patch into the one which introduces +`notmuch-show-tag-all'. + +Regards, + Dmitry + +> > emacs/notmuch-show.el | 23 ++++++++++++++++++++++- +> > 1 files changed, 22 insertions(+), 1 deletions(-) +> > +> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> > index 0d90c1e..b115a8f 100644 +> > --- a/emacs/notmuch-show.el +> > +++ b/emacs/notmuch-show.el +> > @@ -1170,6 +1170,15 @@ All currently available key bindings: +> > (notmuch-show-move-to-message-top) +> > t)) +> > +> > +(defun notmuch-show-mapc (function) +> > + "Iterate through all messages in the current thread with +> > +`notmuch-show-goto-message-next' and call FUNCTION for side +> > +effects." +> > + (save-excursion +> > + (goto-char (point-min)) +> > + (loop do (funcall function) +> > + while (notmuch-show-goto-message-next)))) +> > + +> > ;; Functions relating to the visibility of messages and their +> > ;; components. +> > +> > @@ -1222,6 +1231,18 @@ Some useful entries are: +> > "Return the message id of the current message." +> > (concat "id:\"" (notmuch-show-get-prop :id) "\"")) +> > +> > +(defun notmuch-show-get-messages-ids () +> > + "Return all message ids of messages in the current thread." +> > + (let ((message-ids)) +> > + (notmuch-show-mapc +> > + (lambda () (push (notmuch-show-get-message-id) message-ids))) +> > + message-ids)) +> > + +> > +(defun notmuch-show-get-messages-ids-search () +> > + "Return a search string for all message ids of messages in the +> > +current thread." +> > + (mapconcat 'identity (notmuch-show-get-messages-ids) " or ")) +> > + +> > ;; dme: Would it make sense to use a macro for many of these? +> > +> > (defun notmuch-show-get-filename () +> > @@ -1494,7 +1515,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'." +> > +> > TAG-CHANGES is a list of tag operations for `notmuch-tag'." +> > (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id)) +> > - (apply 'notmuch-tag notmuch-show-thread-id tag-changes) +> > + (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes) +> > (save-excursion +> > (goto-char (point-min)) +> > (loop do (let* ((current-tags (notmuch-show-get-tags))