From: Dmitry Kurochkin Date: Wed, 15 Feb 2012 23:25:59 +0000 (+0400) Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=fb96774a620757b66c8716aa2ed330d8899dbc42;p=notmuch-archives.git Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search --- diff --git a/5d/b731b64501d79d1b6d7853f748a3ec70ca2255 b/5d/b731b64501d79d1b6d7853f748a3ec70ca2255 new file mode 100644 index 000000000..8374a657d --- /dev/null +++ b/5d/b731b64501d79d1b6d7853f748a3ec70ca2255 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BA0E4429E42 + for ; Wed, 15 Feb 2012 15:27:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QcS-lYSpUVRY for ; + Wed, 15 Feb 2012 15:27:23 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 17B4B431E62 + for ; Wed, 15 Feb 2012 15:27:22 -0800 (PST) +Received: by bkcit16 with SMTP id it16so1589642bkc.26 + for ; Wed, 15 Feb 2012 15:27:20 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=v8yMQBJXLgNSC79DkRZNJovacLh1u9B7lw/Dt+HsPJY=; + b=mih0N9cSS453wQRXfy4ZFdHSEhydCih/T553vdRJ0KtmJYVRw1nYiOk5ZanctiNKq7 + 9S+5lfvKYqjdr8MWKMtRpB7UgwrKll/sMln5DUTHGzRlqVn22h7bLv4EWsKn7tIPo+/+ + V4enhjVUlFwj75Xe0jfgBTw3MzjwVYbglFjLM= +Received: by 10.205.127.147 with SMTP id ha19mr67794bkc.64.1329348440319; + Wed, 15 Feb 2012 15:27:20 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id t17sm9317297bke.6.2012.02.15.15.27.19 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 15 Feb 2012 15:27:19 -0800 (PST) +From: Dmitry Kurochkin +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in + notmuch-search +In-Reply-To: <87ehtvheig.fsf@steelpick.2x.cz> +References: <87mx8lpd5o.fsf@nikula.org> + <1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de> + <87wr7ngand.fsf@gmail.com> <87ehtvheig.fsf@steelpick.2x.cz> +User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 16 Feb 2012 03:25:59 +0400 +Message-ID: <87ty2rfzlk.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Feb 2012 23:27:26 -0000 + +On Thu, 16 Feb 2012 00:18:31 +0100, Michal Sojka wrote: +> On Wed, 15 Feb 2012, Dmitry Kurochkin wrote: +> > Hi Michal. +> > +> > On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka wrote: +> > > When notmuch-search-line-faces is used to set background color in search +> > > results, the highlight of the current line is not always displayed +> > > correctly. This patch fixes that by increasing the priority property of +> > > the highlight overlay. +> > > --- +> > +> > How about changing `notmuch-search-color-line' to use text properties +> > instead of overlays? Then hl-line overlay would take priority over it +> > without these changes. +> > +> > See [1] by David Edmondson on why text properties are better in +> > general. I plan to use text properties here to simplify updating the +> > face when tags are changed. +> +> Hmm, I always wondered why notmuch uses overlays even if Elisp manual +> says they don't scale. I remember that I wanted to replace that long +> time ago, but there was some problem, which I forgot. Maybe it was the +> invisibility David mentions. I guess there is some invisible text in +> search output, isn't it? +> + +Yes. Also other faces (e.g. date, subject) are used in search. If we +used properties in `notmuch-search-color-line', we would have to merge +with other properties. So I take my proposal back. + +Regards, + Dmitry + +> -Michal