From: Jameson Graef Rollins Date: Sun, 1 Apr 2012 22:17:04 +0000 (+1700) Subject: Re: [BUG/PATCH v4 0/4] Bug fixes for reply, rebased X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=f9ae1d7e55e4cd92e1280aa295a638d094e84f61;p=notmuch-archives.git Re: [BUG/PATCH v4 0/4] Bug fixes for reply, rebased --- diff --git a/73/3bfef114f7c12e122f59427236d71b4b634425 b/73/3bfef114f7c12e122f59427236d71b4b634425 new file mode 100644 index 000000000..ce90b821c --- /dev/null +++ b/73/3bfef114f7c12e122f59427236d71b4b634425 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E7812431FC0 + for ; Sun, 1 Apr 2012 15:17:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6sbDT-Ukplam for ; + Sun, 1 Apr 2012 15:17:15 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 4FDB7431FAF + for ; Sun, 1 Apr 2012 15:17:15 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id D549E328018; + Sun, 1 Apr 2012 15:17:12 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.193.65]) + (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 8A79732800C; + Sun, 1 Apr 2012 15:17:09 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id EA352906; Sun, 1 Apr 2012 15:17:06 -0700 (PDT) +From: Jameson Graef Rollins +To: Adam Wolfe Gordon , notmuch@notmuchmail.org +Subject: Re: [BUG/PATCH v4 0/4] Bug fixes for reply, rebased +In-Reply-To: <1333293863-14361-1-git-send-email-awg+notmuch@xvx.ca> +References: <1333240404-13076-1-git-send-email-awg+notmuch@xvx.ca> + <1333293863-14361-1-git-send-email-awg+notmuch@xvx.ca> +User-Agent: Notmuch/0.12+93~g9442054 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 01 Apr 2012 15:17:04 -0700 +Message-ID: <87398nm71b.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 01 Apr 2012 22:17:16 -0000 + +--=-=-= + +On Sun, Apr 01 2012, Adam Wolfe Gordon wrote: +> This series is the same as the one from yesterday [1], rebased onto the +> current master to resolve some conflicts with Austin's chnages. +> +> [1] id:"1333240404-13076-1-git-send-email-awg+notmuch@xvx.ca" + +This series applies cleanly against the current master and all tests +pass and it seems to fix all the issues it's meant to address. The code +all looks good to me as well (given my pidgin lisp). + +> Adam Wolfe Gordon (4): +> test: Tests for reply from alternate addresses in emacs +> emacs: Fix two bugs in reply +> test: Show all headers in emacs reply tests + +I really like your justification for the changes to the tests here. +Smart move. + +> emacs: Fix the References header in reply +> +> emacs/notmuch-lib.el | 7 +++- +> emacs/notmuch-mua.el | 36 +++++++++++++++++---- +> test/emacs | 84 +++++++++++++++++++++++++++++++++++++++++++++----- +> 3 files changed, 110 insertions(+), 17 deletions(-) + +LGTM. + +Thanks so much for fixing the remaining issues here, Adam. Good work. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPeNPgAAoJEO00zqvie6q8mzAP/2RRfhKE3L9Rss/iXIzPqh5W +i08WNUQ5t2LwG1Gj+Opx5on9JiABvlZnwk1A0zpgUFpC/GRRD1uGaik/iJLzU4gE +m4/U0VA+8C7a749FsMkQ5v51Qys5HumEvvWiXeCPJ2SwpV64QRnsFvzIYuXCS8aA +KcvUXe2wAgx8DEBMIIWGuoZ73jVOneiJbBQeGYa+VU+mmRi0WlogKPBwTHWlUBlw +aeJPfCgXvVPWYJqYNsu4sYXEGhUAOluhAuP/OD0T+oQx455v37K0O32Bdpym9fzt +KV+z/8ftROJkwfC6R64M8tLMxeySoKYC8/HytMxXMkL6qaKFmGXEDGoAiWkTJzbT +4p06SPiX0Bh8vabKZyoFN0JZAMAe3bg0a2ocA0Xtow3wchwByXmZvMxeemJneXgy +E4ptSNDMrQTZIwX5gPEqB29rJMk6mhHqLovXiBeWrbs3BD5GFT15t+ipPQOymwil +FZAlmyC5bjmvun5umWrMrt0x4j+z1Nh+T4/WI65DC6nw9q/RY3U5J1zcI02DNE89 +T1xTNWwUd4v29V/8MEj9EKfdd7Wb3rF+Y5HoS19OYeHeEUe3iVHMaNR2AnkKPZ2o +dL+umiUKCvKS9WzpA7FODqSNPc/rcdni1aD1yAvOH8yN7lbfsejJZm7yoS0dmqr6 +qxnvCAeMi2rdGDXZhm93 +=csfQ +-----END PGP SIGNATURE----- +--=-=-=--