From: Pieter Praet Date: Mon, 30 Jan 2012 07:18:56 +0000 (+0100) Subject: Re: [PATCH v4?] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}' X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=f8e149aceb4ee1d4a84e09cd380c814a142418d7;p=notmuch-archives.git Re: [PATCH v4?] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}' --- diff --git a/d8/24deeb3b6d1a34d184132c482a468d40f8c9ef b/d8/24deeb3b6d1a34d184132c482a468d40f8c9ef new file mode 100644 index 000000000..707fe98a9 --- /dev/null +++ b/d8/24deeb3b6d1a34d184132c482a468d40f8c9ef @@ -0,0 +1,108 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 96EE9431E64 + for ; Sun, 29 Jan 2012 23:20:59 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.677 +X-Spam-Level: +X-Spam-Status: No, score=-0.677 tagged_above=-999 required=5 + tests=[HS_INDEX_PARAM=0.023, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Z1K6H6fcA-zc for ; + Sun, 29 Jan 2012 23:20:59 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C69B8431FBC + for ; Sun, 29 Jan 2012 23:20:58 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so3325907wib.26 + for ; Sun, 29 Jan 2012 23:20:57 -0800 (PST) +Received: by 10.180.84.105 with SMTP id x9mr25857743wiy.19.1327908056352; + Sun, 29 Jan 2012 23:20:56 -0800 (PST) +Received: from localhost ([109.131.39.11]) + by mx.google.com with ESMTPS id l8sm49538247wiy.5.2012.01.29.23.20.55 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 29 Jan 2012 23:20:55 -0800 (PST) +From: Pieter Praet +To: David Edmondson +Subject: Re: [PATCH v4?] emacs: add `notmuch-show-stash-mlarchive-link{, + -and-go}' +In-Reply-To: +References: <878vkt35ao.fsf@praet.org> + <1327653866-30084-1-git-send-email-pieter@praet.org> + +User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Mon, 30 Jan 2012 08:18:56 +0100 +Message-ID: <87vcnt64kf.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 07:20:59 -0000 + +On Fri, 27 Jan 2012 09:18:40 +0000, David Edmondson wrote: +> Much nicer :-) +> +> On Fri, 27 Jan 2012 09:44:26 +0100, Pieter Praet wrote: +> > +(defcustom notmuch-show-stash-mlarchive-link-alist +> > + '(("Gmane" . "http://mid.gmane.org/") +> > + ("MARC" . "http://marc.info/?i=") +> > + ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=") +> > + ;; FIXME: can these services be searched by `Message-Id' ? +> > + ;; ("MarkMail" . "http://markmail.org/") +> > + ;; ("Nabble" . "http://nabble.com/") +> > + ;; ("opensubscriber" . "http://opensubscriber.com/") +> > + ) +> > + "List of Mailing List Archives to use when stashing links." +> > + :type '(alist :key-type (string :tag "Name") +> > + :value-type (string :tag "URL")) +> > + :group 'notmuch-show) +> +> Add a comment saying that the URI is the result of concatenating this +> with the message id. +> + +Done. + + +> If someone wants to do something more complicated they can submit +> another patch (maybe it should be an option to have the `cdr' be a +> function that is called with the message id as an argument?). +> +> > + (substring (notmuch-show-get-message-id) 4 -1)))) +> +> We should put this logic in one place and re-use it. + +Done. + + +New patches here: + id:"1327907574-12760-1-git-send-email-pieter@praet.org" + id:"1327907574-12760-2-git-send-email-pieter@praet.org" + +For some reason, I've marked them as "v2". :/ + +Note to self: don't send patches while you're still half asleep... + + +Peace + +-- +Pieter