From: Michał Górny <mgorny@gentoo.org>
Date: Thu, 26 Jul 2018 11:12:08 +0000 (+0200)
Subject: desktop.eclass: domenu, remove unnecessary nested loop
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=f6fe42c17ba4a55ea5f13a3bb9c39cc85c790483;p=gentoo.git

desktop.eclass: domenu, remove unnecessary nested loop
---

diff --git a/eclass/desktop.eclass b/eclass/desktop.eclass
index 8f2c6d55c293..08899b4a4607 100644
--- a/eclass/desktop.eclass
+++ b/eclass/desktop.eclass
@@ -244,15 +244,13 @@ domenu() {
 	(
 	# wrap the env here so that the 'insinto' call
 	# doesn't corrupt the env of the caller
-	local i j ret=0
+	local i ret=0
 	insopts -m 0644
 	insinto /usr/share/applications
 	for i in "$@" ; do
 		if [[ -d ${i} ]] ; then
-			for j in "${i}"/*.desktop ; do
-				doins "${j}"
-				((ret|=$?))
-			done
+			doins "${i}"/*.desktop
+			((ret|=$?))
 		else
 			doins "${i}"
 			((ret|=$?))