From: Mark Walters Date: Sun, 30 Sep 2012 15:13:08 +0000 (+0100) Subject: Re: [PATCH 0/5] Notmuch Pick (WIP or contrib) X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=f56f8dac1642922b130b6233e2da5f457371e6e3;p=notmuch-archives.git Re: [PATCH 0/5] Notmuch Pick (WIP or contrib) --- diff --git a/29/542f690a945bc7b67cd5e09bb17d1bfca58277 b/29/542f690a945bc7b67cd5e09bb17d1bfca58277 new file mode 100644 index 000000000..5c32a06d6 --- /dev/null +++ b/29/542f690a945bc7b67cd5e09bb17d1bfca58277 @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 05F99431FB6 + for ; Sun, 30 Sep 2012 08:13:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5HEovb+lYs8T for ; + Sun, 30 Sep 2012 08:13:10 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A43F1431FAE + for ; Sun, 30 Sep 2012 08:13:10 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1TILCc-00058u-Fq; Sun, 30 Sep 2012 16:13:06 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1TILCc-0007Ow-5Y; Sun, 30 Sep 2012 16:13:06 +0100 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/5] Notmuch Pick (WIP or contrib) +In-Reply-To: <87r4prcvon.fsf@convex-new.cs.unb.ca> +References: <1343164911-31589-1-git-send-email-markwalters1009@gmail.com> + <87r4prcvon.fsf@convex-new.cs.unb.ca> +User-Agent: Notmuch/0.14+30~g1894b09 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 30 Sep 2012 16:13:08 +0100 +Message-ID: <87wqzbmtmj.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 9e3c4bb0f03639c3a885b8a8cff15059 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 30 Sep 2012 15:13:15 -0000 + + +Hi + +>> The code is not of the same standard as mainline code: in particular a +>> lot of the code is written by me and is working but unidiomatic +>> lisp. It has also not had widespread testing so I would expect it to +>> have several bugs. +> +> I have gotten the following traceback when running in emacs 24.2.1 if +> the pick buffer is the sole window. It might be related somehow to +> running emacsclient. +> +> Debugger entered--Lisp error: (error "Attempt to delete minibuffer or sole ordinary window") +> signal(error ("Attempt to delete minibuffer or sole ordinary window")) +> error("Attempt to delete minibuffer or sole ordinary window") +> byte-code(" ") +> delete-window(#>) +> notmuch-pick-close-message-window() +> notmuch-pick-quit() +> call-interactively(notmuch-pick-quit nil nil) + +Thanks for this (and sorry to be slow responding): I can reproduce this +error without emacsclient. I have a "fix" which I think is ok but I +want to try a bit more testing before posting anything. + +Thanks + +Mark