From: David Bremner <david@tethera.net>
Date: Fri, 8 Mar 2013 12:05:33 +0000 (+2000)
Subject: Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ef9323238796f2ff4841f62884e43b37e1b24eb6;p=notmuch-archives.git

Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands
---

diff --git a/8b/8fe8c35a2f4bb944efa50b26fb77234cea5853 b/8b/8fe8c35a2f4bb944efa50b26fb77234cea5853
new file mode 100644
index 000000000..a1fb01872
--- /dev/null
+++ b/8b/8fe8c35a2f4bb944efa50b26fb77234cea5853
@@ -0,0 +1,79 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 799FB431FAE
+	for <notmuch@notmuchmail.org>; Fri,  8 Mar 2013 04:05:54 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id nKSqg+eq-NCq for <notmuch@notmuchmail.org>;
+	Fri,  8 Mar 2013 04:05:50 -0800 (PST)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 84639431FAF
+	for <notmuch@notmuchmail.org>; Fri,  8 Mar 2013 04:05:50 -0800 (PST)
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.82.78] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1UDw3S-0008HS-Lr; Fri, 08 Mar 2013 08:05:46 -0400
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1UDw3J-0005Pg-T8; Fri, 08 Mar 2013 08:05:33 -0400
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 5/6] cli: move config open/close to main() from
+	subcommands
+In-Reply-To:
+ <75b8b04e4d63d67ec79ffe2379829add96b37be0.1362347362.git.jani@nikula.org>
+References: <cover.1362347362.git.jani@nikula.org>
+	<75b8b04e4d63d67ec79ffe2379829add96b37be0.1362347362.git.jani@nikula.org>
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org)
+	Emacs/24.3.50.1 (x86_64-pc-linux-gnu)
+Date: Fri, 08 Mar 2013 08:05:33 -0400
+Message-ID: <87obeuaygi.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 08 Mar 2013 12:05:54 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> This allows specifying config file as a top level argument to notmuch,
+> and generally makes it possible to override config file options in
+> main(), without having to touch the subcommands.
+>
+
+I pushed patchs 5 through 7 of this 6 patch series.
+
+- I'll see if I can figure out the elisp needed to work around the
+  "Tramp stomped on my environment variables" problem.
+
+- Is this NEWS worthy? 
+
+- What about a unit test?
+
+- What about updating the tests to use this feature, is that a good idea? 
+
+
+d