From: Daniel Date: Tue, 6 Nov 2012 13:35:22 +0000 (+0100) Subject: Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ee31c72f024de38d8eac826bee8428e3fdc19aa7;p=notmuch-archives.git Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes --- diff --git a/36/fdd8db667bc9c7a75449b5458a3cfeefab5544 b/36/fdd8db667bc9c7a75449b5458a3cfeefab5544 new file mode 100644 index 000000000..12bac234b --- /dev/null +++ b/36/fdd8db667bc9c7a75449b5458a3cfeefab5544 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 266B5431FB6 + for ; Tue, 6 Nov 2012 05:35:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ve3qoXEg+lZt for ; + Tue, 6 Nov 2012 05:35:25 -0800 (PST) +Received: from ecki.hack.org (ecki.hack.org [194.109.217.58]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5633D431FAE + for ; Tue, 6 Nov 2012 05:35:25 -0800 (PST) +Received: from 84-217-31-28.tn.glocalnet.net ([84.217.31.28] + helo=kelebek.lublin.se) + by ecki.hack.org with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) + id 1TVjJL-000G1m-IN + for notmuch@notmuchmail.org; Tue, 06 Nov 2012 14:35:23 +0100 +Received: from quite by kelebek.lublin.se with local (Exim 4.80.1) + (envelope-from ) id 1TVjJK-0002jB-Ql + for notmuch@notmuchmail.org; Tue, 06 Nov 2012 14:35:22 +0100 +Date: Tue, 6 Nov 2012 14:35:22 +0100 +From: Daniel +To: notmuch@notmuchmail.org +Subject: Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes +Message-ID: <20121106133522.GA2029@kelebek.lublin.se> +References: <20121106001633.GA14918@kelebek.lublin.se> + <87d2zro4qj.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87d2zro4qj.fsf@zancas.localnet> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 06 Nov 2012 13:35:26 -0000 + +> > I came across it, having been annoyed by the fact that notmuch broke my reading +> > habits by marking messages (in the mutt sense) as seen, which I hadn't really +> > seen yet in mutt. I tried out the patch; it applied and seems to work. What can +> > I do to make it be applied? Other than giving it some attention. I must say +> > that I have zero insight in the test framework, but if that's what's needed +> > from me... +> +> The patches need to be reviewed for correctness and style. Typically any +> non-trivial patch (or series) needs two reviews. You can see examples in +> the archives of how this works. They are currently marked stale, which +> is supposed to mean they no long apply. On the other hand, if they apply +> for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/ +> for more information about patch tagging). + +I'm completely new to the notmuch core (but have been a user of the alot and +emacs client for a while), and couldn't really say that they are completely +fine. + +But they do apply (with some offset) to current master. They work, seem to do +what they say--and the test runs OK. + +Thus I have now (after having been given access by David) removed +notmuch::stale and added notmuch::needs-review on the following: + +2011-09-15 Louis Rilling +id:"1316039001-32602-4-git-send-email-l.rilling@av7.net" + [PATCH 3/4] test: Adding non-maildir tags does not move message +id:"1316039001-32602-5-git-send-email-l.rilling@av7.net" + [PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change + +And reviewers?