From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 21 Aug 2012 15:25:06 +0000 (+0300)
Subject: Re: [PATCH RFC?] Compactification support
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ea863c32713903a146847a6ed2d34e0ae02f5871;p=notmuch-archives.git

Re: [PATCH RFC?] Compactification support
---

diff --git a/ee/cfad2eb9eb47cbe293afb8c91c81355ea17929 b/ee/cfad2eb9eb47cbe293afb8c91c81355ea17929
new file mode 100644
index 000000000..71624da78
--- /dev/null
+++ b/ee/cfad2eb9eb47cbe293afb8c91c81355ea17929
@@ -0,0 +1,81 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 75E79431FAF
+	for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 08:25:00 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id P08BWqpOKhp5 for <notmuch@notmuchmail.org>;
+	Tue, 21 Aug 2012 08:24:59 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id E8AC8431FAE
+	for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 08:24:58 -0700 (PDT)
+Received: by guru.guru-group.fi (Postfix, from userid 501)
+	id 507C6100386; Tue, 21 Aug 2012 18:25:06 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Ben Gamari <bgamari.foss@gmail.com>, Jani Nikula <jani@nikula.org>,
+	notmuch@notmuchmail.org
+Subject: Re: [PATCH RFC?] Compactification support
+In-Reply-To: <87zk5oz4fh.fsf@gmail.com>
+References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com>
+	<87boi41xdu.fsf@nikula.org> <87zk5oz4fh.fsf@gmail.com>
+User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1
+	(x86_64-redhat-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 21 Aug 2012 18:25:06 +0300
+Message-ID: <m2wr0s6ze5.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 21 Aug 2012 15:25:00 -0000
+
+On Tue, Aug 21 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:
+
+> Jani Nikula <jani@nikula.org> writes:
+>
+>> On Mon, 20 Aug 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:
+>>> Here is a small patchset adding support for database compaction when
+>>> supported by Xapian. Here I add a function which both compacts and
+>>> closes the database.
+>>
+>> What are the benefits of this compared to xapian-compact [1]?
+>>
+> I think it's a bit of a shame you are currently forced to interact with
+> Xapian directly (an implementation detail) to compact the database. This
+> set seeks to abstract this out. This is especially important since it's
+> not too difficult to get the invocation of xapian-compact wrong
+> (e.g. forget --no-renumber).
+
+Better reason would be that xapian-compact(1) may not be available although
+the library is -- if the command is available it is easy to execve(2) it
+with correct arguments... (?)
+
+Tomi
+
+> Also, in the past Carl (id:"87ocl1lut1.fsf@yoom.home.cworth.org") has
+> mentioned it would be nice if compact would be run after the initial run
+> of "notmuch new". This patchset sets the groundwork to enable this.
+>
+> Cheers,
+>
+> - Ben