From: Adam Wolfe Gordon Date: Thu, 23 Feb 2012 21:45:57 +0000 (+1700) Subject: Re: [PATCH 1/2] emacs/cli: remove entire-thread default from show: JSON X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ea1e9f20a2b4b713cd4bbe149b87544d43e27da5;p=notmuch-archives.git Re: [PATCH 1/2] emacs/cli: remove entire-thread default from show: JSON --- diff --git a/9c/eaf5c07d90eac30fac1c06efebcd67f1fc2c7d b/9c/eaf5c07d90eac30fac1c06efebcd67f1fc2c7d new file mode 100644 index 000000000..4f8adbc3e --- /dev/null +++ b/9c/eaf5c07d90eac30fac1c06efebcd67f1fc2c7d @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0D490431FBC + for ; Thu, 23 Feb 2012 13:46:01 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hu39bPNJVS+5 for ; + Thu, 23 Feb 2012 13:45:59 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 463B7431FAE + for ; Thu, 23 Feb 2012 13:45:59 -0800 (PST) +Received: by lahd3 with SMTP id d3so2030997lah.26 + for ; Thu, 23 Feb 2012 13:45:57 -0800 (PST) +Received-SPF: pass (google.com: domain of awg@xvx.ca designates 10.112.87.234 + as permitted sender) client-ip=10.112.87.234; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of awg@xvx.ca designates + 10.112.87.234 as permitted sender) smtp.mail=awg@xvx.ca +Received: from mr.google.com ([10.112.87.234]) + by 10.112.87.234 with SMTP id bb10mr1329286lbb.33.1330033557406 + (num_hops = 1); Thu, 23 Feb 2012 13:45:57 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.112.87.234 with SMTP id bb10mr1108541lbb.33.1330033557336; + Thu, 23 Feb 2012 13:45:57 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.112.114.103 with HTTP; Thu, 23 Feb 2012 13:45:57 -0800 (PST) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <1330033294-21980-2-git-send-email-markwalters1009@gmail.com> +References: <1330033294-21980-1-git-send-email-markwalters1009@gmail.com> + <1330033294-21980-2-git-send-email-markwalters1009@gmail.com> +Date: Thu, 23 Feb 2012 14:45:57 -0700 +X-Google-Sender-Auth: 7X07n7JqhzJXqMoiDOuXt8EGn68 +Message-ID: + +Subject: Re: [PATCH 1/2] emacs/cli: remove entire-thread default from show: + JSON +From: Adam Wolfe Gordon +To: Mark Walters +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQnHbw7+IhnQsBi/UtaPXP08fM67SBpFWUFLqWETTLF1EGWMTYQFs815y1trfI8COZjEPSiy +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 Feb 2012 21:46:01 -0000 + +Hi Mark, + +On Thu, Feb 23, 2012 at 14:41, Mark Walters wro= +te: +> Previously notmuch-show.c defaulted to --entire-thread when +> format=3Djson. =A0Make the default just the matching messages, but make +> the single emacs caller add --entire-thread to the arguments supplied +> so the end result should be unchanged. + +The patch looks good to me. You should probably update the man page as +well, to reflect the change in defauls.