From: Adam Wolfe Gordon Date: Tue, 10 Apr 2012 14:58:45 +0000 (+1800) Subject: Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=e9a9719a316c77deab394062057339cb589b7f8d;p=notmuch-archives.git Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view --- diff --git a/b7/e0c8d97804f4f71ae1f5caafa5793e2b4124bb b/b7/e0c8d97804f4f71ae1f5caafa5793e2b4124bb new file mode 100644 index 000000000..c260b8feb --- /dev/null +++ b/b7/e0c8d97804f4f71ae1f5caafa5793e2b4124bb @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 37C18431FAF + for ; Tue, 10 Apr 2012 07:58:49 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id HV31wGaLqBWE for ; + Tue, 10 Apr 2012 07:58:48 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7E844431FAE + for ; Tue, 10 Apr 2012 07:58:48 -0700 (PDT) +Received: by lban1 with SMTP id n1so2942112lba.26 + for ; Tue, 10 Apr 2012 07:58:45 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:content-type + :content-transfer-encoding:x-gm-message-state; + bh=pOVTuLDM1mQa+ZsFWewuixhusBALFwqr/ScUkYOTtlQ=; + b=OJ4UnJYF7imnypm7rOudl28nWHJjxSJ7AXL8kUTRv/ipPWj55+EVKOSrM0tXC4/c1H + YqnAzFiWqqW5FBLoofaGrL6r9fTwP77rn2SgAYEyAMFJ4swpuKq3IO8sL4N4lnVY618c + d6fAeYAodqBIwODF5Ob1tSdsCASJylVvC5Hqotn20lM7zon9eKRV5Z1DydvxfERA2+5g + 8Uoc4DXVhE6VcDDgFPr833RXiufof0oAi0MFaz0CEyK6k3wzH/wgEvo85cw8ZIRj/XDI + NKGduNSvaWOWP/97YUAJwS3V1Lby4Fhk7uQ1NjxfMiE/fqiplCG8nTQNOGHDw2rh7Tbd + LTUQ== +MIME-Version: 1.0 +Received: by 10.152.148.234 with SMTP id tv10mr15115570lab.41.1334069925415; + Tue, 10 Apr 2012 07:58:45 -0700 (PDT) +Sender: awg@xvx.ca +Received: by 10.112.97.14 with HTTP; Tue, 10 Apr 2012 07:58:45 -0700 (PDT) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <1331351655-16921-1-git-send-email-dmitry.kurochkin@gmail.com> +References: <1331351655-16921-1-git-send-email-dmitry.kurochkin@gmail.com> +Date: Tue, 10 Apr 2012 08:58:45 -0600 +X-Google-Sender-Auth: _MSbnhY_ypk6F3d0cvrfL8ryVTo +Message-ID: + +Subject: Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view +From: Adam Wolfe Gordon +To: notmuch@notmuchmail.org +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQnHya2LwFt6D3JtZ+FjKdqJwMCtMw5NojWLjFbeet1F/EStsMyqMZhlp4yL/v3/Qk2jfkBs +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 10 Apr 2012 14:58:50 -0000 + +On Fri, Mar 9, 2012 at 20:54, Dmitry Kurochkin + wrote: +> This patch removes trailing spaces in notmuch-hello view. +> +> A side effect of this change is that tag/query buttons no longer +> include a space at the end. =A0This means that pressing RET when the +> point is at the first character after the tag/query button no longer +> works (note that this is the standard behavior for buttons). =A0We may +> change this behavior in the future (without adding trailing spaces +> back) if people would find this change inconvenient. + +LGTM, and works as expected. + +(Sorry if you get this twice, Dmitry.)