From: Dmitry Kurochkin Date: Sun, 29 Jan 2012 23:09:38 +0000 (+0400) Subject: Re: [PATCH 4/6] test: fix emacs tests after tagging operations changes X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=e559c6ee6238da1911c64f548a8e85a9735f1f84;p=notmuch-archives.git Re: [PATCH 4/6] test: fix emacs tests after tagging operations changes --- diff --git a/4d/d4ef58a7ccba3d47f3ac9e0095d1ed9aa3b48a b/4d/d4ef58a7ccba3d47f3ac9e0095d1ed9aa3b48a new file mode 100644 index 000000000..741762959 --- /dev/null +++ b/4d/d4ef58a7ccba3d47f3ac9e0095d1ed9aa3b48a @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3438B429E57 + for ; Sun, 29 Jan 2012 15:10:50 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id iQESay1g4FRp for ; + Sun, 29 Jan 2012 15:10:49 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9D1D4429E54 + for ; Sun, 29 Jan 2012 15:10:49 -0800 (PST) +Received: by bke11 with SMTP id 11so870975bke.26 + for ; Sun, 29 Jan 2012 15:10:48 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=9Ti4cQabq+sg8C0YE61dY040y+/IGxAgesgK+UIQ7Pk=; + b=B/a3qv6W6iX1DdUASmRSiUiFJYfZ0b1Wx3Nw2KjbS2Ph8vInK2A4kJnJayGen0je/A + GKG4IiXsfGE2Zii89iwnFHg6klUwK9LMaIhivhsFNKFFATuU8JRZtH0fMbXhVBVHudkS + venWYL9iamfdfJlPPGp7bNYRrakdmt16tuVBQ= +Received: by 10.204.152.219 with SMTP id h27mr7451627bkw.40.1327878648322; + Sun, 29 Jan 2012 15:10:48 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id d2sm33295507bky.11.2012.01.29.15.10.47 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 29 Jan 2012 15:10:47 -0800 (PST) +From: Dmitry Kurochkin +To: Austin Clements +Subject: Re: [PATCH 4/6] test: fix emacs tests after tagging operations + changes +In-Reply-To: <20120129225841.GH17991@mit.edu> +References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> + <1327725684-5887-4-git-send-email-dmitry.kurochkin@gmail.com> + <20120129225841.GH17991@mit.edu> +User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 30 Jan 2012 03:09:38 +0400 +Message-ID: <87d3a285sd.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 29 Jan 2012 23:10:50 -0000 + +On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements wrote: +> Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: +> > After the recent tagging operations changes, functions bound to "+" +> > and "-" in notmuch-search and notmuch-show views always read input +> > from the minibuffer. Use kbd macros instead of calling them directly. +> +> Should this be folded into the previous patch so these tests aren't +> temporarily broken? + +I think it is a common approach for notmuch. IIRC I sent patches which +changes both code and tests, and I was asked to move the tests to a +separate patch. So I will leave it as is for now. Though if you point +me to a relevant discussion or policy, which says that the tests should +be merged, I would be happy to do it. + +Regards, + Dmitry