From: Jameson Graef Rollins Date: Mon, 23 Jul 2012 19:16:32 +0000 (+1700) Subject: Re: [PATCH v2 0/4] Add a --body option to notmuch show X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=e50e3d746c1627c9f86a3e485a8d793abe21be48;p=notmuch-archives.git Re: [PATCH v2 0/4] Add a --body option to notmuch show --- diff --git a/bf/3a3c17123d17bf26a286170a67569968c14dc8 b/bf/3a3c17123d17bf26a286170a67569968c14dc8 new file mode 100644 index 000000000..952e51222 --- /dev/null +++ b/bf/3a3c17123d17bf26a286170a67569968c14dc8 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4FEA3431FB6 + for ; Mon, 23 Jul 2012 12:16:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id v2GUH8xqlwoj for ; + Mon, 23 Jul 2012 12:16:39 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id A63AA431FAE + for ; Mon, 23 Jul 2012 12:16:39 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 272302E50C64; + Mon, 23 Jul 2012 12:16:37 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (gwave-65.ligo.caltech.edu [131.215.114.65]) + (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 6BD532E507F2; + Mon, 23 Jul 2012 12:16:34 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 506599A0; Mon, 23 Jul 2012 12:16:34 -0700 (PDT) +From: Jameson Graef Rollins +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/4] Add a --body option to notmuch show +In-Reply-To: <1343066259-22523-1-git-send-email-markwalters1009@gmail.com> +References: <1343066259-22523-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.13.2+90~gb97ff6a (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Mon, 23 Jul 2012 12:16:32 -0700 +Message-ID: <87eho270fj.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 23 Jul 2012 19:16:40 -0000 + +--=-=-= + +On Mon, Jul 23 2012, Mark Walters wrote: +> Version 2 of this patch set (version 1 at +> id:"1343060241-18283-1-git-send-email-markwalters1009@gmail.com"). This +> corrects the errors Austin spotted in v1, and makes it explicit that +> --body=false and --part>0 are incompatible. +> +> +> Mark Walters (4): +> cli: add --body=true|false option to notmuch-show.c +> test: add tests for the new --body=true|false option +> man: update man page for the new --body=true|false option +> schemata: update for --body=true|false option +> +> devel/schemata | 2 +- +> man/man1/notmuch-show.1 | 16 ++++++++++++++++ +> notmuch-client.h | 3 ++- +> notmuch-reply.c | 2 +- +> notmuch-show.c | 30 ++++++++++++++++++++++-------- +> test/json | 9 +++++++++ +> 6 files changed, 51 insertions(+), 11 deletions(-) + +Untested, but LGTM. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQDaMQAAoJEO00zqvie6q8MyoQAJ2cm7+wyBzF0Ks/z+sqf++B +fIp+Z52AF2+FuMtXov4XmHCW5817AanmEuCoDdYSacg+Au5E88xuUjLR5En/d8J8 +wG+1q1ktnrlpsP7lTZISRN9u4OeK00y+TvBt6wbqEZIZygBRX34ueBlnNiuq1jMK +jxacJSmuKsr1l0V1G88wBgO5bnqCKggitdkfbjcQYb+wm3rIpWgya1yN3fU4RGxW +l5Wsdq+FJZvvYZot9hHd/3P7GMJVOcYFyy2sh3i0lPyOs2JbBIK4piJmZHx7SP/A +nBEGcRdNXW7E1sB5tP+IGuXvVexxJ+N1m/HiSNbo9OnMjGdgyz7mMSicC6KRuAZ3 +Q/Y3MHsKKu97uNSC25Hd+HbqEusyINYEug8wL0CZ9eirfK22UkVG6xKGTztI9NRn +TleTd1g2XOchUUJr62m9EvgsCXKD8aY7f9VikBg2Ct5s9iEZe3GFZ4Ls3zEj31hH +11JB0oIEPnPohqg3Bf1OiiWrDD04OzrNeONJZHWawUYd2PK/aOGD+9XdkppxHfgW +Wq0t3Karb0guMKYk4Ib65xFm1tr62/Ww7sCrv/uS3SDHXoRCHQOoVgbqqYTa0RM4 +ma6OVAUPIBxRsIGFOzeKhfq3p7xe09yVLESytQ7xH/zUna/HmieETrkk167pKYIX +eoXSaShdBRXklcCbyd4T +=DhcT +-----END PGP SIGNATURE----- +--=-=-=--