From: Adam Wolfe Gordon Date: Wed, 2 May 2012 17:39:14 +0000 (+1800) Subject: Re: [PATCH] emacs: Do not pass stderr of notmuch reply to JSON parser X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=e4a361c417462e49330c331c352d6381eef7bef7;p=notmuch-archives.git Re: [PATCH] emacs: Do not pass stderr of notmuch reply to JSON parser --- diff --git a/cf/49dfb86c3c104f1bfcd8542e2c2a946f0a01ef b/cf/49dfb86c3c104f1bfcd8542e2c2a946f0a01ef new file mode 100644 index 000000000..48ef91b2c --- /dev/null +++ b/cf/49dfb86c3c104f1bfcd8542e2c2a946f0a01ef @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A873A431FAF + for ; Wed, 2 May 2012 10:39:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OFef29ZX6YcY for ; + Wed, 2 May 2012 10:39:16 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 89E6F431FAE + for ; Wed, 2 May 2012 10:39:16 -0700 (PDT) +Received: by lahc1 with SMTP id c1so698753lah.26 + for ; Wed, 02 May 2012 10:39:14 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:cc:content-type + :x-gm-message-state; + bh=9QsnD/+2o4jW8tGf1+EnJFQQGxos/Eisq22lHmq4h9A=; + b=eRS11reOvYYreU0xPrVkpWPKnkk39+Irq5qF3jBaQzWdTUMoQarRF+RanvfISaquXC + Rt6aE86nARix49YjJF6kLkibTw5kn9h18LZP3Xp6odey85Wl7+hTqX+gA/kA7SadblGW + O203MJZn5xOjZe+EfPD8/x2iiBokfh//l9ufbkcr46dC7OL8a5Kd7zLWenzg1yk54vs0 + VFYHU8Q31fOAQmCMVRmLAu27tm/TMRn5QIGXvrcU7+b69+KK/4O89A1I902BnkR8vnfc + PnEGGIbhVefKXCxsg/FIKOqZ4Tfh8YUxcnDgR+8p7mIVk5Redbl+yhnk23rV1svLSG6m + L1Ow== +MIME-Version: 1.0 +Received: by 10.152.112.97 with SMTP id ip1mr27662218lab.31.1335980354702; + Wed, 02 May 2012 10:39:14 -0700 (PDT) +Sender: awg@xvx.ca +Received: by 10.112.82.163 with HTTP; Wed, 2 May 2012 10:39:14 -0700 (PDT) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <1335906647-23422-1-git-send-email-sojkam1@fel.cvut.cz> +References: + + <1335906647-23422-1-git-send-email-sojkam1@fel.cvut.cz> +Date: Wed, 2 May 2012 11:39:14 -0600 +X-Google-Sender-Auth: mVkjEWJ70IvNV7QHcVglOs14jho +Message-ID: + +Subject: Re: [PATCH] emacs: Do not pass stderr of notmuch reply to JSON parser +From: Adam Wolfe Gordon +To: Michal Sojka +Content-Type: text/plain; charset=ISO-8859-1 +X-Gm-Message-State: + ALoCoQlO/nEXE8QiCCpFCAdZ2bNVsffi5Usa86FvtK5i+oi2pDyTEIKYQIL5TxlHr7++OF06ykkF +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 02 May 2012 17:39:17 -0000 + +On Tue, May 1, 2012 at 3:10 PM, Michal Sojka wrote: +> Sometimes, notmuch reply outputs something to stderr, for example: +> "Failed to verify signed part: Cannot verify multipart/signed part: +> unsupported signature protocol". When this happens, replying in emacs +> fails, because emacs cannot parse the error message as JSON. +> +> This patch causes emacs to ignore stderr when reading reply from +> notmuch. + +LGTM, as I said in the other thread. Thanks for the fix. + +-- Adam