From: Sergei Trofimovich <slyfox@gentoo.org>
Date: Mon, 7 May 2018 12:18:57 +0000 (+0100)
Subject: media-video/smplayer: drop -Werror to allow gcc-8, bug #654724
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=e101ecc3740756d2b69c369791f6ecb4c264ae9d;p=gentoo.git

media-video/smplayer: drop -Werror to allow gcc-8, bug #654724

gcc-8 covers even more potential buffer overflow conditions.
This causes new build failure due to blanket -Werror in smplayer.

For more details see Gentoo's take on -Werror handling in devmanual:
https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

Reported-by: Mike Lothian
Closes: https://bugs.gentoo.org/654724
Package-Manager: Portage-2.3.36, Repoman-2.3.9
---

diff --git a/media-video/smplayer/files/smplayer-18.3.0-disable-werror.patch b/media-video/smplayer/files/smplayer-18.3.0-disable-werror.patch
new file mode 100644
index 000000000000..7905a44619f6
--- /dev/null
+++ b/media-video/smplayer/files/smplayer-18.3.0-disable-werror.patch
@@ -0,0 +1,9 @@
+gcc-8 is smarter about possible overflow detection.
+
+Reported-by: Mike Lothian
+Bug: https://bugs.gentoo.org/654724
+--- a/webserver/Makefile
++++ b/webserver/Makefile
+@@ -5 +5 @@ SOURCES = main.c mongoose.c
+-CFLAGS = -O2 -W -Wall -Werror -Wno-unused-function $(CFLAGS_EXTRA) $(MODULE_CFLAGS)
++CFLAGS = -O2 -W -Wall -Wno-unused-function $(CFLAGS_EXTRA) $(MODULE_CFLAGS)
diff --git a/media-video/smplayer/smplayer-18.3.0.ebuild b/media-video/smplayer/smplayer-18.3.0.ebuild
index d8ae8f1fe3c6..711f309f6bec 100644
--- a/media-video/smplayer/smplayer-18.3.0.ebuild
+++ b/media-video/smplayer/smplayer-18.3.0.ebuild
@@ -48,6 +48,7 @@ PATCHES=(
 	"${FILESDIR}/${PN}-14.9.0.6966-unbundle-qtsingleapplication.patch" # bug 487544
 	"${FILESDIR}/${PN}-17.1.0-advertisement_crap.patch"
 	"${FILESDIR}/${PN}-18.2.0-jobserver.patch"
+	"${FILESDIR}/${PN}-18.3.0-disable-werror.patch"
 )
 
 src_prepare() {
diff --git a/media-video/smplayer/smplayer-18.4.0.ebuild b/media-video/smplayer/smplayer-18.4.0.ebuild
index 27c383e46b9f..8b62e36f20f2 100644
--- a/media-video/smplayer/smplayer-18.4.0.ebuild
+++ b/media-video/smplayer/smplayer-18.4.0.ebuild
@@ -48,6 +48,7 @@ PATCHES=(
 	"${FILESDIR}/${PN}-14.9.0.6966-unbundle-qtsingleapplication.patch" # bug 487544
 	"${FILESDIR}/${PN}-17.1.0-advertisement_crap.patch"
 	"${FILESDIR}/${PN}-18.2.0-jobserver.patch"
+	"${FILESDIR}/${PN}-18.3.0-disable-werror.patch"
 )
 
 src_prepare() {