From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 27 Oct 2012 12:12:29 +0000 (+0300)
Subject: Re: [PATCH v4 0/3] split async json parser into utility function
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=df156918a7b42fd7c7bf62adc5c5bc8f5ae25745;p=notmuch-archives.git

Re: [PATCH v4 0/3] split async json parser into utility function
---

diff --git a/2e/899b2c69807ac2055a30ca8506c37e2714f3ed b/2e/899b2c69807ac2055a30ca8506c37e2714f3ed
new file mode 100644
index 000000000..afaaa17e7
--- /dev/null
+++ b/2e/899b2c69807ac2055a30ca8506c37e2714f3ed
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id C4F6E431FBF
+	for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 05:12:29 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id zfDaN7cM0y8u for <notmuch@notmuchmail.org>;
+	Sat, 27 Oct 2012 05:12:29 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id D6556431FAF
+	for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 05:12:28 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id ECCDC100045;
+	Sat, 27 Oct 2012 15:12:29 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v4 0/3] split async json parser into utility function
+In-Reply-To: <1351330452-8348-1-git-send-email-markwalters1009@gmail.com>
+References: <1351330452-8348-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.14+59~gf9031cd (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 27 Oct 2012 15:12:29 +0300
+Message-ID: <m2bofoqfki.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 27 Oct 2012 12:12:29 -0000
+
+On Sat, Oct 27 2012, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> This is version 4 of this patch set (v3 is at
+> id:"1351037602-11157-1-git-send-email-markwalters1009@gmail.com"). It
+> splits the async json parser into its own function and moves it to
+> lib.
+>
+> This version is very similar to v3 except that it finished by moving
+> the utility function to lib rather than leaving it notmuch.el. It also
+> improves some of the docstrings to clarify how the function and
+> variables work. I have not gone quite as far as suggested by Ethan as
+> these variables are purely for internal use and Austin's code is well
+> documented.
+
+Changes look good and tests pass.
+
+Tomi
+
+> Best wishes
+>
+> Mark
+>
+>
+> Mark Walters (3):
+>   emacs: Split out the incremental json parser into its own function
+>   emacs: Rename incremental JSON internal variables
+>   emacs: Move the incremental JSON parser to notmuch-lib.el
+>
+>  emacs/notmuch-lib.el |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++
+>  emacs/notmuch.el     |   48 +++---------------------------------
+>  2 files changed, 70 insertions(+), 44 deletions(-)
+>
+> -- 
+> 1.7.9.1
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch