From: James Vasile Date: Wed, 7 Nov 2012 14:20:02 +0000 (+1900) Subject: Re: [PATCH] fix notmuch_database_open call in addrlookup X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ded1e71f49e47060c155b407dc205bc67cdfc751;p=notmuch-archives.git Re: [PATCH] fix notmuch_database_open call in addrlookup --- diff --git a/61/ef0c606df0e4290407c36dbb0673be408edae1 b/61/ef0c606df0e4290407c36dbb0673be408edae1 new file mode 100644 index 000000000..fed6424b8 --- /dev/null +++ b/61/ef0c606df0e4290407c36dbb0673be408edae1 @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E212F431FC2 + for ; Wed, 7 Nov 2012 06:31:58 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.01 +X-Spam-Level: +X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 + tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ZQQtjv3DxFm5 for ; + Wed, 7 Nov 2012 06:31:57 -0800 (PST) +Received: from mail.sflc.info (mail.sflc.info [207.86.247.70]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CD01E431FB6 + for ; Wed, 7 Nov 2012 06:31:57 -0800 (PST) +Received: from localhost (unknown [74.113.160.38]) + by mail.sflc.info (Postfix) with ESMTPSA id 315B2B4C01D; + Wed, 7 Nov 2012 14:31:56 +0000 (UTC) +From: James Vasile +To: Ethan Glasser-Camp , + notmuch mailing list +Subject: Re: [PATCH] fix notmuch_database_open call in addrlookup +In-Reply-To: <87625jidlr.fsf@betacantrips.com> +References: <87ip9q4moj.fsf@hackervisions.org> + <87625jidlr.fsf@betacantrips.com> +User-Agent: Notmuch/0.14+96~gb732e1b (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Wed, 07 Nov 2012 09:20:02 -0500 +Message-ID: <87y5idijfx.fsf@jamesvasile.com> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 07 Nov 2012 14:31:59 -0000 + +--=-=-= + +Ethan Glasser-Camp writes: + +> James Vasile writes: +> +>> What's the best way to submit changes to addrlookup? Right now, it is +>> out of date vs the latest libnotmuch. The addrlookup repo is vala code +>> but the wiki [1] points to a generated c file [2]. +>> +>> [1] http://github.com/spaetz/vala-notmuch/raw/static-sources/src/addrlookup.c +>> [2] http://notmuchmail.org/emacstips/ +>> +>> At any rate, a patch to that c file is below. If you upgraded notmuch +>> and now addrlookup gives errors about not finding libnotmuch.so.2, this +>> patch might be what you need. +> +> I'd try to contact the author of the code, perhaps by submitting an +> issue or pull request on the github page for the project. I'm sure he'd +> prefer a patch to the Vala source. +> +> Ethan + +Thanks, will do. My vala is weak, so a patch to the vala source is +unlikely to make it to the front of my queue this year. I'll ping +Sebastian Spaeth directly and via github. + +-J + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQEcBAEBAgAGBQJQmm4SAAoJECaDklOuuidYl/AIAK0hnTFYxUtg9eIp30ba6EGa +Xu9VkKMW+8odLdxCeHJZYOjm2o/jxlhQfWf7koT/FpfQUosx1UkCMoe32kmVXzjO +jRph3RAQxxEdO35WgADQ9twA8p9/vkmbVFnIbyk8FXn1FUabWFlG4c0bpmtDehca +Fl8a+0eea5iFKNXUtU+qAovPbt99t49lHqASedz4RGbCU8TL8oYMoicew3SngYGK +07b4tfH7sHTiu2uiSp9JQfVfbYsWxPXSKgFsAx7mDtaCR/LSw3YVFUOXEylb1vsu +Lj0WChi3+06Rm6cryECw0ajULr8c6l0WeIBvF+ADkGRFvVcAQr3WnGmdBKr+RHo= +=956C +-----END PGP SIGNATURE----- +--=-=-=--