From: Mark Walters Date: Sun, 15 Jul 2012 18:14:44 +0000 (+0100) Subject: Re: [PATCH v3 0/8] emacs: JSON-based search cleanups X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=dd2e21dc2c02b7dfe8476b56b8c544699b9480ca;p=notmuch-archives.git Re: [PATCH v3 0/8] emacs: JSON-based search cleanups --- diff --git a/6b/0e061d126e78c52cb32e75a7771ff862dfda82 b/6b/0e061d126e78c52cb32e75a7771ff862dfda82 new file mode 100644 index 000000000..1e65169ea --- /dev/null +++ b/6b/0e061d126e78c52cb32e75a7771ff862dfda82 @@ -0,0 +1,128 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 87319431FCF + for ; Sun, 15 Jul 2012 11:14:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id M7fR1RXSanXx for ; + Sun, 15 Jul 2012 11:14:50 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9CA44431FBC + for ; Sun, 15 Jul 2012 11:14:50 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SqTLD-0002Wd-Ad; Sun, 15 Jul 2012 19:14:47 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SqTLC-000331-Ul; Sun, 15 Jul 2012 19:14:47 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 0/8] emacs: JSON-based search cleanups +In-Reply-To: <87ipdorjja.fsf@awakening.csail.mit.edu> +References: <1342140319-19859-1-git-send-email-amdragon@mit.edu> + <1342306940-7499-1-git-send-email-amdragon@mit.edu> + <87a9z1at22.fsf@qmul.ac.uk> + <87ipdorjja.fsf@awakening.csail.mit.edu> +User-Agent: Notmuch/0.13.2+90~g84fa1ef (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 15 Jul 2012 19:14:44 +0100 +Message-ID: <87y5mkuc17.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 7f81cbcee7c29ced1a24c8172869462e (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Jul 2012 18:14:51 -0000 + +On Sun, 15 Jul 2012, Austin Clements wrote: +> On Sun, 15 Jul 2012, Mark Walters wrote: +>> On Sun, 15 Jul 2012, Austin Clements wrote: +>>> This version swaps out the notmuch-search-do-results macro for a +>>> higher-order function, notmuch-search-foreach-result. This requires +>>> less squiting to understand and clearly distinguishes the arguments +>>> passed in to the function from the arguments passed to the callback. +>>> This version also updates the docstring for +>>> notmuch-search-result-format to mention that multi-line result formats +>>> work and how to enter them, and it adds a NEWS patch. +>> +>> Hello +>> +>> I am afraid I have found a minor (but reproducible) bug in the line +>> re-drawing even with single line results. Find a search result with a +>> partially elided author field and put the cursor after the ellipsis in +>> that line. Then update the tags. The result gets redrawn with ellipsis +>> written out in full. Re-redrawing with the cursor after the author field +>> redraws the line with the keeping the ellipsis written out in full, +>> whereas re-redrawing the line with cursor before the author field gets +>> it written with the correct ellipsis. +> +> Arrrg, overlays. +> +> I can think of two ways to fix this. We could generate the author +> elision overlays lazily (say, via jit-lock). This would have the added +> benefit of eliminating what I think is the last quadratic factor in +> building search buffers, but there are much easier ways to do that. Or, +> I could scrap the insert-before-markers nonsense and manipulate point +> directly in notmuch-search-update-result, with the caveat that the +> little bit of support it had for doing sane things in some situations +> involving save-excursions would be lost. Given that we never call +> notmuch-search-update-result inside a save-excursion (precisely because +> I couldn't reliably hit the narrow window of situations it could handle +> when there were save-excursions involved), I'd lean toward the latter +> option. + +I think I don't really know enough emacs/lisp to be able to say anything +sensible. I think manipulating point directly seems good because then I +think we can make sure things work in the multiline case too. + +I haven't yet worked out whether multiline is an amusing "oh look it works" +or genuinely useful thing. I am leaning towards the latter as do often +work on laptops with quite small screens and think I would like to see +more about a smaller number of results. + +Best wishes + +Mark +