From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Thu, 10 May 2012 14:36:50 +0000 (+0200) Subject: Re: Last minute fixes to the go bindings X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=dc669cf4e1e65b20e4381ec3b735488b34f921af;p=notmuch-archives.git Re: Last minute fixes to the go bindings --- diff --git a/d0/c2b57afc45c1a01e1dd77918a3c856c79dd0d1 b/d0/c2b57afc45c1a01e1dd77918a3c856c79dd0d1 new file mode 100644 index 000000000..df2337e33 --- /dev/null +++ b/d0/c2b57afc45c1a01e1dd77918a3c856c79dd0d1 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C452E431FAF + for ; Thu, 10 May 2012 07:36:57 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nJn3QRKhoBDl for ; + Thu, 10 May 2012 07:36:55 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 77F0A431FAE + for ; Thu, 10 May 2012 07:36:55 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 651BC589EE1 + for ; Thu, 10 May 2012 16:36:53 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id D3B87DF2A3; Thu, 10 May 2012 16:36:52 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de + [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client + certificate requested) (Authenticated sender: teythoon) by + mail.jade-hamburg.de (Postfix) with ESMTPSA id 19990DF2A0; Thu, 10 May 2012 + 16:36:50 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) + (envelope-from ) + id 1SSUU6-0006JR-9L; Thu, 10 May 2012 16:36:50 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +To: Austin Clements , +From: Justus Winter <4winter@informatik.uni-hamburg.de> +In-Reply-To: <20120509180700.GA11804@mit.edu> +References: + <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de> + <20120509180700.GA11804@mit.edu> +Message-ID: <20120510143650.5975.92158@thinkbox.jade-hamburg.de> +User-Agent: alot/0.3+ +Subject: Re: Last minute fixes to the go bindings +Date: Thu, 10 May 2012 16:36:50 +0200 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 10 May 2012 14:36:57 -0000 + +Quoting Austin Clements (2012-05-09 20:07:00) +> LGTM. +> = + +> Quoth Justus Winter on May 09 at 12:23 pm: +> > Hi everyone :) +> > = + +> > this is a small patch series that I'd like to see included in 0.13. +> > = + +> > The first patch updates notmuch-addrlookup with respect to Austins +> > recent change of the notmuch_database_open function. This fixes the +> > compilation of the utility. +> > = + +> > The second patch fixes the values of all the STATUS_* constants. Turns +> > out all of them were set to zero by accident. This isn't a c style +> > enum, golang has the iota operator to do this kind of stuff. This +> > fixes the error handling for all the users of the go bindings. +> = + +> 'Doh! Is it possible to get the status values out of cgo, rather than +> depending on the list in libnotmuch and the list in Go being in the +> same order? + +Yes, it is and I've prepared a patch. But since I'm living in go 1 +land here I prepared it on top of my go 1 patchset and I'm thinking of +sending it once that one got merged. + +@David: what do you think about merging this patch set? + +Justus