From: Pieter Praet Date: Wed, 1 Feb 2012 13:51:37 +0000 (+0100) Subject: Re: emacs: quote MML tags in replies X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=db9fb8666cd7754f707ad8a1331184d49c459193;p=notmuch-archives.git Re: emacs: quote MML tags in replies --- diff --git a/ce/894823c3842046d6bc4453ac80d28ebcdf6342 b/ce/894823c3842046d6bc4453ac80d28ebcdf6342 new file mode 100644 index 000000000..2120a7de7 --- /dev/null +++ b/ce/894823c3842046d6bc4453ac80d28ebcdf6342 @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8428D429E5B + for ; Wed, 1 Feb 2012 05:53:35 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EmcD6Bt0B-W3 for ; + Wed, 1 Feb 2012 05:53:34 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8CB41431E64 + for ; Wed, 1 Feb 2012 05:53:34 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so975837wib.26 + for ; Wed, 01 Feb 2012 05:53:33 -0800 (PST) +Received: by 10.180.95.131 with SMTP id dk3mr11141356wib.6.1328104413380; + Wed, 01 Feb 2012 05:53:33 -0800 (PST) +Received: from localhost ([109.131.39.11]) + by mx.google.com with ESMTPS id di5sm74039832wib.3.2012.02.01.05.53.32 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 01 Feb 2012 05:53:32 -0800 (PST) +From: Pieter Praet +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: emacs: quote MML tags in replies +In-Reply-To: <1328064581-13949-1-git-send-email-dmitry.kurochkin@gmail.com> +References: <1326998589-37187-1-git-send-email-aaronecay@gmail.com> + <1328064581-13949-1-git-send-email-dmitry.kurochkin@gmail.com> +User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Wed, 01 Feb 2012 14:51:37 +0100 +Message-ID: <87vcnq64ra.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Feb 2012 13:53:35 -0000 + +On Wed, 1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin wrote: +> Hi Aaron. +> +> Thanks for your work! I took the liberty to do some cleanups for your +> patch. Below is a detailed list of changes. +> + +Thanks to the both of you! + + +> Hope this helps. +> +> Changes since v2: +> +> * change patch names to be consistent with others: +> +> - s/emacs:/test:/ for the test patch +> +> - lower case the first word after colon in the patch title +> +> * polish NEWS wording, move it to 0.12 section +> +> * add comment to `mml-quote-region' call, as suggested by Tomi [1] +> +> * fix and clean up the test: +> +> - set `notmuch-fcc-dirs' to nil to avoid adding the Fcc header, +> otherwise it breaks the test on other systems as pointed by +> David [2] +> + +Could also have been avoided by adding the expected result inline, +and using "Fcc: $(pwd)/mail/sent". I'll send an updated patch to +that effect. + + +> - use default values for add_message parameters where possible +> +> - use a sane subject value in add_message +> +> - use shorter MML tag as produced by (mml-insert-part) +> +> - indenting and other minor cleanups +> +> Regards, +> Dmitry +> +> [1] id:"m2wr89ioos.fsf@guru.guru-group.fi" +> [2] id:"87ehugzycb.fsf@zancas.localnet" +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch + +Despite my comment re Fcc, both LGTM. + + +Peace + +-- +Pieter