From: Mark Walters Date: Sun, 4 Mar 2012 23:52:35 +0000 (+0000) Subject: Re: [PATCH] emacs: keep customizations in groups X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=daef12303f06033535b9bde331a89b0714db581a;p=notmuch-archives.git Re: [PATCH] emacs: keep customizations in groups --- diff --git a/ab/6874954d0bf384c67853e033a8a7a8f5addb7d b/ab/6874954d0bf384c67853e033a8a7a8f5addb7d new file mode 100644 index 000000000..a84d09df7 --- /dev/null +++ b/ab/6874954d0bf384c67853e033a8a7a8f5addb7d @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5E585431FAF + for ; Sun, 4 Mar 2012 15:50:52 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id FA+c9l6CTNez for ; + Sun, 4 Mar 2012 15:50:51 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 76B2C431FAE + for ; Sun, 4 Mar 2012 15:50:51 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1S4LCO-0000ep-AV; Sun, 04 Mar 2012 23:50:46 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1S4LCN-0001gn-Sb; Sun, 04 Mar 2012 23:50:44 +0000 +From: Mark Walters +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: keep customizations in groups +In-Reply-To: <1330811724-30901-1-git-send-email-jani@nikula.org> +References: <1330811724-30901-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.11.1+295~gfd64f6e (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sun, 04 Mar 2012 23:52:35 +0000 +Message-ID: <87d38r6i0s.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 10e93d7b982fa40c4bd3c0fd1e1b52d4 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 04 Mar 2012 23:50:52 -0000 + +On Sat, 3 Mar 2012 23:55:24 +0200, Jani Nikula wrote: +> Move hello section customization to notmuch-hello group and printing +> customization to notmuch-show group from the top level customization +> group. + +Hi + +This is an clear improvement but I wonder about the positioning of these +two options inside the subgroups. It makes + +notmuch-hello-sections the last option under notmuch-hello and + +notmuch-print-mechanism the first option under notmuch-show + +both of which seem slightly strange positions. + +(Personally I would place notmuch-hello-sections towards the top, and +notmuch-print-mechanism towards the bottom. If you decided on this +ordering then I am happy to go with it: I am only commenting in case it +is just accidental.) + +Best wishes + +Mark + + + +> --- +> emacs/notmuch-hello.el | 2 +- +> emacs/notmuch-print.el | 2 +- +> 2 files changed, 2 insertions(+), 2 deletions(-) +> +> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el +> index e089290..0cf613f 100644 +> --- a/emacs/notmuch-hello.el +> +++ b/emacs/notmuch-hello.el +> @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count of messages +> displayed next to the buttons can be generated by applying a +> different filter to the tag query. These filters are also +> supported for \"Customized queries section\" items." +> - :group 'notmuch +> + :group 'notmuch-hello +> :type +> '(repeat +> (choice (function-item notmuch-hello-insert-header) +> diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el +> index 6653d97..8c18f4b 100644 +> --- a/emacs/notmuch-print.el +> +++ b/emacs/notmuch-print.el +> @@ -25,7 +25,7 @@ +> +> (defcustom notmuch-print-mechanism 'notmuch-print-lpr +> "How should printing be done?" +> - :group 'notmuch +> + :group 'notmuch-show +> :type '(choice +> (function :tag "Use lpr" notmuch-print-lpr) +> (function :tag "Use ps-print" notmuch-print-ps-print) +> -- +> 1.7.5.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch