From: Ethan Date: Thu, 18 Oct 2012 13:37:41 +0000 (+2000) Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggl... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=d844c7b63e167f1541e7144092e4dc14a4c33fda;p=notmuch-archives.git Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' --- diff --git a/55/70ed609ee691a74585350bef2097b54b803751 b/55/70ed609ee691a74585350bef2097b54b803751 new file mode 100644 index 000000000..4d6d25273 --- /dev/null +++ b/55/70ed609ee691a74585350bef2097b54b803751 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 024CA431FBF + for ; Thu, 18 Oct 2012 06:37:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.798 +X-Spam-Level: +X-Spam-Status: No, score=-0.798 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0JS2yYH554ci for ; + Thu, 18 Oct 2012 06:37:44 -0700 (PDT) +Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com + [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DB1B5431FB6 + for ; Thu, 18 Oct 2012 06:37:43 -0700 (PDT) +Received: by mail-vb0-f53.google.com with SMTP id fc21so8977710vbb.26 + for ; Thu, 18 Oct 2012 06:37:41 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type; + bh=5nmzY4iJ7rWb4yKuiWWKrtcm6GDMJGkHfeuDynePnug=; + b=GXS9Lp1UCtgxe2J+/RWEUsdgdPdrMizX0q3jZRkx6poj2AMMvKHIFiKe37a2krFWTl + Qhb2p19W9bQawjU9xVrhCYrLJKj8ZmpPrvoA5d7RnuHYv8SB/NFsYwXa2S5A36rjP1Ev + RMUXzgnYPn+HwbCcObY9XGFTlaz7qXpQo5vlT/Vt8h/n1rW+zYnz7BEHYvb54uK6fzxI + 6s9ecU5OiefwTHY/4MyXOgBVsGbPfG5jOe/i9LNUuorWbTatvxsfhVneM9Bz+OIuIqyg + M5DHNigHVizdy18NksWMEkzpF90u6jG+9Enm3FVwO7lCYu5HQWXG5fr3pGnpBzBOm3Un + fg0g== +MIME-Version: 1.0 +Received: by 10.59.8.133 with SMTP id dk5mr15660579ved.19.1350567461744; Thu, + 18 Oct 2012 06:37:41 -0700 (PDT) +Received: by 10.220.247.209 with HTTP; Thu, 18 Oct 2012 06:37:41 -0700 (PDT) +In-Reply-To: +References: <1327469139-1968-1-git-send-email-pieter@praet.org> + <1329936214-30959-3-git-send-email-pieter@praet.org> + <87k3uv9xuo.fsf@betacantrips.com> <877gqo8vx2.fsf@betacantrips.com> + +Date: Thu, 18 Oct 2012 09:37:41 -0400 +Message-ID: + +Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to + `notmuch-show-toggle-visibility-headers' +From: Ethan +To: Tomi Ollila +Content-Type: multipart/alternative; boundary=047d7beb91d6cd6fb104cc557d42 +Cc: Notmuch Mail , Pieter Praet +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 18 Oct 2012 13:37:45 -0000 + +--047d7beb91d6cd6fb104cc557d42 +Content-Type: text/plain; charset=ISO-8859-1 + +On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote: + +> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote: +> +> > Ethan Glasser-Camp writes: +> > +> >> This patch, and its predecessors, all look great to me. +> > +> > But a note: many of the first lines in your commit messages ("{show, +> +> Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and +> those are converted to spaces in git-am (??) +> + +I guess this is called "line folding" and notmuch should be sure to undo +it, as I guess git-am already does. + +https://bugs.launchpad.net/mailman/+bug/265915 + +I guess I can stop complaining about it ;) Patches 1-3 are probably ready +then. Thanks, Tomi. + +Ethan + +--047d7beb91d6cd6fb104cc557d42 +Content-Type: text/html; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable + +
On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila <= +tomi.ollila@iki.fi> wrote:
+
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
+
+
> Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> writes:
+>
+>> This patch, and its predecessors, all look great to me.
+>
+> But a note: many of the first lines in your commit messages ("{sh= +ow,
+
+
Hmm, first lines -- IIRC mailman adds those tabs to the subject line = +-- and
+those are converted to spaces in git-am (??)

I gue= +ss this is called "line folding" and notmuch should be sure to un= +do it, as I guess git-am already does.

https://bugs.launchpad.net/mailman/+bug/26591= +5
+
I guess I can stop complaining about it ;) Patches 1-3 are probably rea= +dy then. Thanks, Tomi.

Ethan

+ +--047d7beb91d6cd6fb104cc557d42--