From: Austin Clements Date: Thu, 25 Oct 2012 02:11:11 +0000 (+2000) Subject: Re: [PATCH] test: Fix HTML rendering test X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=d53257ee588318cfc3c0cee296e024377b9dc7ab;p=notmuch-archives.git Re: [PATCH] test: Fix HTML rendering test --- diff --git a/b4/54307fe40c0ae6bd2ed43876f4079bd69e9ac3 b/b4/54307fe40c0ae6bd2ed43876f4079bd69e9ac3 new file mode 100644 index 000000000..9e3e1f03f --- /dev/null +++ b/b4/54307fe40c0ae6bd2ed43876f4079bd69e9ac3 @@ -0,0 +1,125 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 589CC431FAF + for ; Wed, 24 Oct 2012 19:11:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QZNcilWodVP3 for ; + Wed, 24 Oct 2012 19:11:14 -0700 (PDT) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id A5B24431FAE + for ; Wed, 24 Oct 2012 19:11:14 -0700 (PDT) +X-AuditID: 12074424-b7fce6d000000925-f3-50889fc11f25 +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id 83.4F.02341.1CF98805; Wed, 24 Oct 2012 22:11:14 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q9P2BDtN031262; + Wed, 24 Oct 2012 22:11:13 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q9P2BBxi001864 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 24 Oct 2012 22:11:12 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1TRCud-0007Oe-Iy; Wed, 24 Oct 2012 22:11:11 -0400 +Date: Wed, 24 Oct 2012 22:11:11 -0400 +From: Austin Clements +To: Ethan Glasser-Camp +Subject: Re: [PATCH] test: Fix HTML rendering test +Message-ID: <20121025021111.GW14861@mit.edu> +References: <1351109160-11105-1-git-send-email-amdragon@mit.edu> + <873913joqz.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <873913joqz.fsf@betacantrips.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42IRYrdT1z00vyPA4OQ+Jos7PbtYLK7fnMns + wOSxc9Zddo9nq24xBzBFcdmkpOZklqUW6dslcGUcP7aUteCuUMW0k7PYGxh/8XUxcnJICJhI + 3PpwihXCFpO4cG89WxcjF4eQwD5Gid/vfjJDOBsYJX52fGSEcE4ySTy7vI8JwlnCKHH/13Kg + Hg4OFgFVic7+FJBRbAIaEtv2L2cECYsImEr8PagOEmYWkJb49ruZCcQWFjCSuHT+GJjNK6Aj + 8XbaI3aQciGBFIkr/QUQYUGJkzOfsEC0aknc+PeSCaQEZMzyfxwgYU4BPYlzj5+zgdiiAioS + U05uY5vAKDQLSfcsJN2zELoXMDKvYpRNya3SzU3MzClOTdYtTk7My0st0jXXy80s0UtNKd3E + CA5pF5UdjM2HlA4xCnAwKvHwHvDoCBBiTSwrrsw9xCjJwaQkyrt0DlCILyk/pTIjsTgjvqg0 + J7X4EKMEB7OSCO/kB+0BQrwpiZVVqUX5MClpDhYlcd7rKTf9hQTSE0tSs1NTC1KLYLIyHBxK + ErxT5gENFSxKTU+tSMvMKUFIM3FwggznARpuD1LDW1yQmFucmQ6RP8Woy3H0zdyHjEIsefl5 + qVLivNNBigRAijJK8+DmwFLRK0ZxoLeEeetBqniAaQxu0iugJUxAS8x5WkGWlCQipKQaGFk2 + 8VvtOVVlVxBj1zdZRu5Xen7Yi4lfAiMfLXm9MaY/MmIxa/7je92dEbN8X37zE74z4zKz5F7V + SSEpcya9jhfbzd9r68pSrNiffic+5pBMs+uJ4If8E6s3hp4O9ihubZZw/RQuvSBAyURsdlyd + ctDBnJUv9pZPOb9yZqVvr5fHp7fNK0UDlViKMxINtZiLihMBZ+bQTSADAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 25 Oct 2012 02:11:15 -0000 + +Quoth Ethan Glasser-Camp on Oct 24 at 9:59 pm: +> Austin Clements writes: +> +> > The test designed to exercise Emacs' rendering of HTML emails +> > containing images inadvertently assumed w3m was available under Emacs +> > 23. The real point of this test was to exercise Emacs 24's shr +> > renderer, so if shr isn't available, we now fall back to html2text, +> > which comes with Emacs. +> +> Hi! I'm eager to apply any patch here that makes this better. But this +> one doesn't fix it for me (24.1.1, although it seems to work with +> 23.4.1). OUTPUT is "*\nsmiley " (no space after the asterisk or before +> the word smiley, but after). I see that this sed command is supposed to +> normalize things, but at least on my setup, it doesn't. I also see "nil" +> written to console, but I have no idea what that's about. + +Emacs seems to have as many ways to convert HTML to text as there are +people trying to run this test. What's the value of +mm-text-html-renderer for you in Emacs 24? + +> More generally, I guess I don't understand exactly what this test is +> supposed to be exercising. The commit message says "the shr renderer", +> but what about it? In +> id:"1348941314-8377-4-git-send-email-amdragon@mit.edu" you write that +> using shr raised a void-variable error previously, so maybe we're making +> sure that error doesn't show up? In that case, even my semi-broken +> output is good enough. + +Yes; this is essentially a regression test. I would prefer not to +catch exceptions in this test because I think we'll eventually start +eating exceptions in body renderers to prevent them from breaking the +rest of the show buffer. We could check that the output contains the +word "smiley" somewhere as evidence that it probably didn't crash. + +> In a perfect world, test probably shouldn't succeed if shr isn't +> present, but should note that it wasn't run. Maybe the emacs lisp code +> can check for shr, and if it's not present, write "shr not present" to +> an output file, and the shell code can grep for that and then call +> test_skip if it sees it? + +That's another possibility. Unfortunately, skipped tests seem rather +heavyweight in the test infrastructure and get reported loudly, which +would affect anyone running the tests under Emacs 23. + +> Still, I'm excited that you're working on this so please let's get it +> fixed! +> +> Ethan