From: Peter Wang Date: Sun, 25 Nov 2012 01:16:40 +0000 (+1100) Subject: [PATCH v2 14/20] insert: fsync after writing tmp file X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=d356ce5e9fff039bba50b291d36f6bd7dba17e1c;p=notmuch-archives.git [PATCH v2 14/20] insert: fsync after writing tmp file --- diff --git a/3f/3d21cdafef4da424e3c47e814e4fa10146991d b/3f/3d21cdafef4da424e3c47e814e4fa10146991d new file mode 100644 index 000000000..4a8916781 --- /dev/null +++ b/3f/3d21cdafef4da424e3c47e814e4fa10146991d @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A8679431FAF + for ; Sat, 24 Nov 2012 17:18:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sYsehKSp+Zvs for ; + Sat, 24 Nov 2012 17:18:24 -0800 (PST) +Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com + [209.85.160.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4502A431FAE + for ; Sat, 24 Nov 2012 17:18:24 -0800 (PST) +Received: by mail-pb0-f53.google.com with SMTP id jt11so7944513pbb.26 + for ; Sat, 24 Nov 2012 17:18:24 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; + bh=0ngTvqX/MGy5FRVrbSMHwO8FgImgilRhjT4Oplgn2oI=; + b=tZq+IQbDDsTfC2XJXdWKqvwXoTaOVcfgJXJCEK481nyw4B7ZEH6VVYzHOSswOF7d5/ + VHkgTm9strC7r2g2Hjil3P7RSK/yEievbX2PLaoL6mAFJ5fUE8g3bYKKY2LjyMQQ3p20 + qDMVmyeyAciSwcXVzmaV3zNUFRJCKt7S34qyn6Sr2BEq6olZdtZJpzhLS2BkXK/5kUbr + mZM0OGIN71daYRMWEpyy8L64XDAsjeYn+9z5Sk+AFOiI8HsWwEbEVLsaxgmidWGciWL9 + 4YBiRl04gdHgfjI9bAavCorX6Q/J0LKiujyxvakmi5HRrZBwdW4gybqjDbIQupbW+BTi + o0Kw== +Received: by 10.68.239.104 with SMTP id vr8mr26538950pbc.59.1353806304036; + Sat, 24 Nov 2012 17:18:24 -0800 (PST) +Received: from localhost (215.42.233.220.static.exetel.com.au. + [220.233.42.215]) + by mx.google.com with ESMTPS id tm8sm6224230pbc.48.2012.11.24.17.18.21 + (version=TLSv1/SSLv3 cipher=OTHER); + Sat, 24 Nov 2012 17:18:23 -0800 (PST) +From: Peter Wang +To: notmuch@notmuchmail.org +Subject: [PATCH v2 14/20] insert: fsync after writing tmp file +Date: Sun, 25 Nov 2012 12:16:40 +1100 +Message-Id: <1353806206-29133-15-git-send-email-novalazy@gmail.com> +X-Mailer: git-send-email 1.7.12.1 +In-Reply-To: <1353806206-29133-1-git-send-email-novalazy@gmail.com> +References: <1353806206-29133-1-git-send-email-novalazy@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 25 Nov 2012 01:18:24 -0000 + +Flush the tmp file to disk after writing for durability. +--- + notmuch-insert.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/notmuch-insert.c b/notmuch-insert.c +index b7aef95..f09c579 100644 +--- a/notmuch-insert.c ++++ b/notmuch-insert.c +@@ -329,6 +329,10 @@ insert_message (void *ctx, notmuch_database_t *notmuch, int fdin, + return FALSE; + } + ret = copy_fd_data (fdin, fdout); ++ if (ret && fsync (fdout) != 0) { ++ fprintf (stderr, "Error: fsync failed: %s\n", strerror (errno)); ++ ret = FALSE; ++ } + close (fdout); + if (ret) { + ret = maildir_move_tmp_to_new (tmppath, newpath); +-- +1.7.12.1 +