From: Tomi Ollila Date: Thu, 6 Sep 2012 08:57:01 +0000 (+0300) Subject: Re: [PATCH v2] emacs: Add customization group for replying X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=d0bcc298646e362112c53facd742078add184415;p=notmuch-archives.git Re: [PATCH v2] emacs: Add customization group for replying --- diff --git a/7c/fb197aef7c2d4e09e6a3fafb17623d8722d0a6 b/7c/fb197aef7c2d4e09e6a3fafb17623d8722d0a6 new file mode 100644 index 000000000..38f438973 --- /dev/null +++ b/7c/fb197aef7c2d4e09e6a3fafb17623d8722d0a6 @@ -0,0 +1,129 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B5826431FAF + for ; Thu, 6 Sep 2012 01:56:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id IOigcepbM0-o for ; + Thu, 6 Sep 2012 01:56:56 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id DBFCE431FAE + for ; Thu, 6 Sep 2012 01:56:55 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id BEBDB1000E5; + Thu, 6 Sep 2012 11:57:01 +0300 (EEST) +From: Tomi Ollila +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Add customization group for replying +In-Reply-To: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz> +References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz> +User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 06 Sep 2012 08:56:56 -0000 + +On Thu, Sep 06 2012, Michal Sojka wrote: + +> When one wants to customize the format of reply message, there is nothing +> to tell the user how to do it. Without knowing that construction of +> reply buffer is actually implemented in the message package, it seems +> that replying cannot be customized. +> +> Because I was getting annoyed by the empty line the between the citation +> line and the quoted message, I figured out that changing this is fairly +> easy when one knows what to customize. +> +> This patch adds notmuch-reply customization group that contains +> references to the relevant customization options. The new group is easy +> to find as it is shown as a result of running "M-x customize-group RET +> notmuch RET". +> --- + +So far good, but... + +You forgot to handle the current group setting for +notmuch-message-replied-tags -- currently notmuch-message.el has this: + +(defcustom notmuch-message-replied-tags '("replied") + "Tags to be automatically added to or removed from a message when it is + replied to. +Any tag in the list will be added to a replied message or, +if it is prefaced with a \"-\", removed. + +For example, if you wanted to add a \"replied\" tag and remove +the \"inbox\" and \"todo\", you would set + (\"replied\" \"-inbox\" \"-todo\"\)" + :type 'list + :group 'notmuch-send) + +If the above was changed to 'normuch-send, (require 'notmuch-lib) +was added to the beginning of notmuch-message.el and the defgroup +below was written as + +(defgroup notmuch-reply + '((message-insertion custom-group))) + "Replying to messages. + ... + +would that work as expected ? + +Tomi + + +> emacs/notmuch-lib.el | 10 ++++++++++ +> 1 file changed, 10 insertions(+) +> +> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el +> index 900235b..c045a32 100644 +> --- a/emacs/notmuch-lib.el +> +++ b/emacs/notmuch-lib.el +> @@ -45,6 +45,16 @@ +> "Showing messages and threads." +> :group 'notmuch) +> +> +(defgroup notmuch-reply +> + '((message-insertion custom-group) +> + (notmuch-message-replied-tags custom-variable)) +> + "Replying to messages. +> + +> +Most of the reply customization settings can be found in `Message +> +insertion' group. Notmuch specific settings is included directly +> +here." +> + :group 'notmuch) +> + +> (defgroup notmuch-send nil +> "Sending messages from Notmuch." +> :group 'notmuch) +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch