From: Ethan Glasser-Camp Date: Fri, 12 Oct 2012 21:36:31 +0000 (+2000) Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggl... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=cc81787b68dc73256ea6559827f6fe615bf915fc;p=notmuch-archives.git Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' --- diff --git a/79/df78f26d1b4857b6cc3e98ca5e4ad6768b7c76 b/79/df78f26d1b4857b6cc3e98ca5e4ad6768b7c76 new file mode 100644 index 000000000..bad66779c --- /dev/null +++ b/79/df78f26d1b4857b6cc3e98ca5e4ad6768b7c76 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 25746431FAF + for ; Fri, 12 Oct 2012 14:36:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6kqoj3X6xt8S for ; + Fri, 12 Oct 2012 14:36:39 -0700 (PDT) +Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com + [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 87FC4431FAE + for ; Fri, 12 Oct 2012 14:36:39 -0700 (PDT) +Received: by mail-qa0-f46.google.com with SMTP id c26so93195qad.5 + for ; Fri, 12 Oct 2012 14:36:39 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=2pPuUcZ6NlNnbqhokT0+wOkZpWMNK9ma1WBown38qrI=; + b=fVs+EKzvwOfH3OJ4tRheL92UZ4oxDXhqWmVpQs4DzLhpI9Vw3AUVHA6mxpFusTYa2w + 6AfyRqa2m9ojvGA2iiUoJuZiMt0Eh385Upp7ZmSYGAqsvqFKolvBWJKm6jOwrZcZYDAt + WdNs0HebvGvL0LLsFTfFQ+3NBaeU0be5RTotX0YmIognbPiuOMSNzu/6lW5efi2uwIG8 + CoKFYDbopWQtuZ1QYuNsO/2LwalpRTkHwFc5LcUShBJMpnALA5dRq+qqlGbW3X97fmxz + h9DH55CvW+c7yxTTWyhyHIitQLpKtAIJPp1Rodi0Let+A5mZOhVtHd2bzFIy7AgQnl9Y + Amsg== +Received: by 10.49.63.97 with SMTP id f1mr12796120qes.4.1350077798973; + Fri, 12 Oct 2012 14:36:38 -0700 (PDT) +Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) + by mx.google.com with ESMTPS id gx8sm8248339qab.12.2012.10.12.14.36.36 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 12 Oct 2012 14:36:37 -0700 (PDT) +From: Ethan Glasser-Camp +To: Pieter Praet , Notmuch Mail +Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to + `notmuch-show-toggle-visibility-headers' +In-Reply-To: <1329936214-30959-3-git-send-email-pieter@praet.org> +References: <1327469139-1968-1-git-send-email-pieter@praet.org> + <1329936214-30959-3-git-send-email-pieter@praet.org> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 12 Oct 2012 17:36:31 -0400 +Message-ID: <87k3uv9xuo.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 12 Oct 2012 21:36:40 -0000 + +Pieter Praet writes: + +> * emacs/notmuch-show.el +> +> (notmuch-show-toggle-headers): +> Rename to `notmuch-show-toggle-visibility-headers'. + +This patch, and its predecessors, all look great to me. The following +patches were already marked "stale" (and indeed they don't apply). But +it looks like David Edmonson gave his +1 on the idea, so maybe you +should rebase them. + +Side note: how do you write these tests? How do you generate what the +output should look like? Copy/paste from a "real" emacs session? You +have generated an awful lot of tests :) + +Ethan