From: David Bremner Date: Mon, 26 Nov 2012 12:44:27 +0000 (+2000) Subject: Re: [Patch v4 2/2] test: initial performance testing infrastructure X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ca94d23e5ce7ec724aa810b9d8c248ac1d08b6de;p=notmuch-archives.git Re: [Patch v4 2/2] test: initial performance testing infrastructure --- diff --git a/30/36446455429cd001b5f8da6e09a4d2e8914ed2 b/30/36446455429cd001b5f8da6e09a4d2e8914ed2 new file mode 100644 index 000000000..265f830e7 --- /dev/null +++ b/30/36446455429cd001b5f8da6e09a4d2e8914ed2 @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 812AD431FAF + for ; Mon, 26 Nov 2012 04:44:58 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id JDhYqtYv8bOZ for ; + Mon, 26 Nov 2012 04:44:58 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1F9E1431FAE + for ; Mon, 26 Nov 2012 04:44:58 -0800 (PST) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1Tcy3S-0008S0-Iy; Mon, 26 Nov 2012 08:44:54 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1Tcy31-000242-O2; Mon, 26 Nov 2012 08:44:27 -0400 +From: David Bremner +To: Austin Clements +Subject: Re: [Patch v4 2/2] test: initial performance testing infrastructure +In-Reply-To: <20121126032906.GP4562@mit.edu> +References: <1353855745-11697-1-git-send-email-david@tethera.net> + <1353855745-11697-3-git-send-email-david@tethera.net> + <20121125214023.GO4562@mit.edu> <87obilut2h.fsf@zancas.localnet> + <20121126032906.GP4562@mit.edu> +User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Mon, 26 Nov 2012 08:44:27 -0400 +Message-ID: <87lidov8ic.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 26 Nov 2012 12:44:58 -0000 + +Austin Clements writes: +> +> The README definitely helps. Might still be worth a comment in the +> code since it took me some thinking to realize it would do something +> reasonable when given no argument. Perhaps above the initial +> assignment of arg, + +I decided to fix the code, rather than comment it ;). Now every code +path makes an explicit, non-empty assignment to $arg + +I have pushed that slightly updated version of the patches. + +d + +