From: James Vasile Date: Wed, 7 Nov 2012 14:15:34 +0000 (+1900) Subject: Re: [PATCH] don't show x-foo tags in search view X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ca3f0daf77ed2ebe31d67a50aed9af1014809e0f;p=notmuch-archives.git Re: [PATCH] don't show x-foo tags in search view --- diff --git a/e1/9c200104979be3064fdeff50e0de46dcaa9cdb b/e1/9c200104979be3064fdeff50e0de46dcaa9cdb new file mode 100644 index 000000000..986841d18 --- /dev/null +++ b/e1/9c200104979be3064fdeff50e0de46dcaa9cdb @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5C4E7431FB6 + for ; Wed, 7 Nov 2012 06:31:56 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.01 +X-Spam-Level: +X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 + tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SqeyzoP6dE+o for ; + Wed, 7 Nov 2012 06:31:55 -0800 (PST) +Received: from mail.sflc.info (mail.sflc.info [207.86.247.70]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B1A77431FAE + for ; Wed, 7 Nov 2012 06:31:55 -0800 (PST) +Received: from localhost (unknown [74.113.160.38]) + by mail.sflc.info (Postfix) with ESMTPSA id 82F4CB4C018; + Wed, 7 Nov 2012 14:31:53 +0000 (UTC) +From: James Vasile +To: David Bremner +Subject: Re: [PATCH] don't show x-foo tags in search view +In-Reply-To: <871ug5k2g1.fsf@zancas.localnet> +References: <87fw4x3y3e.fsf@hackervisions.org> + <87liepw0b4.fsf@convex-new.cs.unb.ca> + <87625tc6xd.fsf@hackervisions.org> <20121030005700.GE15377@mit.edu> + <87390w57oo.fsf@hackervisions.org> <871ug5k2g1.fsf@zancas.localnet> +User-Agent: Notmuch/0.14+96~gb732e1b (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Wed, 07 Nov 2012 09:15:34 -0500 +Message-ID: <87390ljy7t.fsf@jamesvasile.com> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +Cc: notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 07 Nov 2012 14:31:56 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +David Bremner writes: +> James Vasile writes: +> +>> Austin, +>> +>> Thanks for the helpful comments. I redid the patch to take a list of +>> regexps. That way users can banish different kinds of tags or simply +>> list the tags themselves. I've responded to your comments in text below +>> the patch. +>> +> +> I think the patch is probably OK now contentwise, but the commit message +> is what I quoted above, which is not ideal.=20=20 + +New commit message: + +This patch hides any tags in search view that match the regexps +specified in the list `notmuch-search-hide-tag-regexps`. The match is +case-insensitive. An empty list (which is the default) will disable +hiding of tags in search view. The list can be set via setq or the +customize interface. To hide all tags that begin with "x-" or "X-", set +`notmuch-search-hide-tag-regexps` to "^X-". + + +> +> As far as being obsoleted by Damien's labeller patches, let's cross that +> bridge when we come to it. Unless somebody objects, I'd be willing to +> push some version of this now. + +Thanks. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQEcBAEBAgAGBQJQmm0GAAoJECaDklOuuidYBigH/3mVIrTJrdjBkBz+GM+syg6Q +ZW5c73oyDMAInTc0us1GpOaWK0l4tiMz4uVDyibT6L/ncdwpibXzHARN6xphi6yC +JVPvHBEgEIbLC3/+QDETRoqG4x32WE3+/+B8EilPOr2s0cG8FdTtQWuIf0opWlz7 +nAlgTyVtrIFhxO79IHXXv0BY9lBWdJLsuap747HVooitgzEVOZac90Ccr3B5tKsn +ZquBIhOwUETwTwuv4FJa4a8S0eCqEAUvQ9+rT7Ro0WBO/lrAoJXy/o/anRuIJR8j +AUltsZ5yXNUPj2wm6li0abiYRBr10TqW8TvZUf4mZrE6WiyrZHSdsI9HfH6v7WI= +=X1jy +-----END PGP SIGNATURE----- +--=-=-=--