From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Mon, 24 Sep 2012 10:31:54 +0000 (+0200) Subject: [PATCH 2/5] RFC: Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=c8c2fc6713df9f2f0f7169a27aeb1048f4a8fb9e;p=notmuch-archives.git [PATCH 2/5] RFC: Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE --- diff --git a/31/2ddb9a6099e3dd55d87c1abc1e44da9ae6ad52 b/31/2ddb9a6099e3dd55d87c1abc1e44da9ae6ad52 new file mode 100644 index 000000000..57efa68a3 --- /dev/null +++ b/31/2ddb9a6099e3dd55d87c1abc1e44da9ae6ad52 @@ -0,0 +1,106 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A0F0C431FBD + for ; Mon, 24 Sep 2012 03:32:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.001 +X-Spam-Level: +X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 + tests=[UNPARSEABLE_RELAY=0.001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5jk+3yYuOVRZ for ; + Mon, 24 Sep 2012 03:32:27 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4DADD431FD6 + for ; Mon, 24 Sep 2012 03:32:24 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id E06905AA9CD + for ; Mon, 24 Sep 2012 12:32:22 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id 4C33FDF2A6; Mon, 24 Sep 2012 12:32:22 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (unknown + [IPv6:fe80::216:d3ff:fe3e:5058%br0]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) (Authenticated sender: teythoon) + by mail.jade-hamburg.de (Postfix) with ESMTPSA id 46F03DF2A5; + Mon, 24 Sep 2012 12:32:12 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80) + (envelope-from ) + id 1TG5xR-0002i5-QR; Mon, 24 Sep 2012 12:32:09 +0200 +From: Justus Winter <4winter@informatik.uni-hamburg.de> +To: notmuch@notmuchmail.org +Subject: [PATCH 2/5] RFC: Provide a NORETURN_ATTRIBUTE macro similar to + PRINTF_ATTRIBUTE +Date: Mon, 24 Sep 2012 12:31:54 +0200 +Message-Id: + <1348482717-10340-3-git-send-email-4winter@informatik.uni-hamburg.de> +X-Mailer: git-send-email 1.7.10.4 +In-Reply-To: + <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de> +References: <20120922161256.GE26662@mit.edu> + <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 24 Sep 2012 10:32:28 -0000 + +This attribute is understood by gcc since version 2.5. clang provides +support for testing for function attributes using __has_attribute. For +other compilers this macro evaluates to the empty string. + +Note: This is work in progress, please don't merge this patch. The +question that needs to be discussed is where this kind of macro should +be defined. + +Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de> +--- + util/error_util.h | 16 ++++++++++++++++ + 1 file changed, 16 insertions(+) + +diff --git a/util/error_util.h b/util/error_util.h +index 1b11047..27e119f 100644 +--- a/util/error_util.h ++++ b/util/error_util.h +@@ -31,6 +31,22 @@ + #define __has_attribute(x) 0 + #endif + ++/* Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE from ++ * talloc. ++ * ++ * This attribute is understood by gcc since version 2.5. clang ++ * provides support for testing for function attributes. ++ */ ++#ifndef NORETURN_ATTRIBUTE ++#if (__GNUC__ >= 3 || \ ++ (__GNUC__ == 2 && __GNUC_MINOR__ >= 5) || \ ++ __has_attribute (noreturn)) ++#define NORETURN_ATTRIBUTE __attribute__ ((noreturn)) ++#else ++#define NORETURN_ATTRIBUTE ++#endif ++#endif ++ + /* There's no point in continuing when we've detected that we've done + * something wrong internally (as opposed to the user passing in a + * bogus value). +-- +1.7.10.4 +