From: Zac Medico <zmedico@gentoo.org>
Date: Sun, 20 Apr 2008 20:50:48 +0000 (-0000)
Subject: Bug #218559 - Make portdbapi automatically add sandbox write access to
X-Git-Tag: v2.2_pre6~142
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=c829201cd5e92666b3610b46dec0391e62fbe16e;p=portage.git

Bug #218559 - Make portdbapi automatically add sandbox write access to
self.depcachedir when appropriate. This makes the portageq blanket sandbox
exemption unnecessary.

svn path=/main/trunk/; revision=9928
---

diff --git a/bin/portageq b/bin/portageq
index eb0d0ff69..c3fe8b37d 100755
--- a/bin/portageq
+++ b/bin/portageq
@@ -21,10 +21,6 @@ except KeyboardInterrupt:
 
 import os
 
-# This allows portageq to be exempt from sandbox,
-# for things like updating metadata cache.
-os.environ["SANDBOX_ON"] = "0"
-
 import types
 
 #-----------------------------------------------------------------------------
diff --git a/pym/portage/dbapi/porttree.py b/pym/portage/dbapi/porttree.py
index 845fdbae5..3c0bc01b5 100644
--- a/pym/portage/dbapi/porttree.py
+++ b/pym/portage/dbapi/porttree.py
@@ -62,7 +62,16 @@ class portdbapi(dbapi):
 		#self.root=settings["PORTDIR"]
 		self.porttree_root = os.path.realpath(porttree_root)
 
-		self.depcachedir = self.mysettings.depcachedir[:]
+		self.depcachedir = os.path.realpath(self.mysettings.depcachedir)
+
+		if os.environ.get("SANDBOX_ON") == "1":
+			# Make api consumers exempt from sandbox violations
+			# when doing metadata cache updates.
+			sandbox_write = os.environ.get("SANDBOX_WRITE", "").split(":")
+			if self.depcachedir not in sandbox_write:
+				sandbox_write.append(self.depcachedir)
+				os.environ["SANDBOX_WRITE"] = \
+					":".join(filter(None, sandbox_write))
 
 		self.eclassdb = eclass_cache.cache(self.porttree_root,
 			overlays=self.mysettings["PORTDIR_OVERLAY"].split())