From: Mark Walters Date: Fri, 13 Jul 2012 18:12:37 +0000 (+0100) Subject: Re: [PATCH 0/7] emacs: JSON-based search cleanups X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=c7747eb7a39c72a454437b193aad32502e4dee7c;p=notmuch-archives.git Re: [PATCH 0/7] emacs: JSON-based search cleanups --- diff --git a/ba/944d46782955ef10debf0917ad3a470cea1c38 b/ba/944d46782955ef10debf0917ad3a470cea1c38 new file mode 100644 index 000000000..778d8ff92 --- /dev/null +++ b/ba/944d46782955ef10debf0917ad3a470cea1c38 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E8508431FC4 + for ; Fri, 13 Jul 2012 11:12:41 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1NylKbB7GRhL for ; + Fri, 13 Jul 2012 11:12:41 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3DA8C431FAE + for ; Fri, 13 Jul 2012 11:12:41 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SpkM3-00075S-Cg; Fri, 13 Jul 2012 19:12:39 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SpkM2-0006PS-Ti; Fri, 13 Jul 2012 19:12:39 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/7] emacs: JSON-based search cleanups +In-Reply-To: <1342140319-19859-1-git-send-email-amdragon@mit.edu> +References: <1342140319-19859-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.13.2+63~g1397edd (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 13 Jul 2012 19:12:37 +0100 +Message-ID: <871ukf8r8q.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 316907bef6bda2e77b4dc8be5c6f512a (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 13 Jul 2012 18:12:42 -0000 + +On Fri, 13 Jul 2012, Austin Clements wrote: +> This series builds on the JSON-based search series [0] to clean up +> several other aspects of search-mode. It removes constraints on the +> formatting of tags in the result line (you can even leave them out +> entirely), it recolors lines when tags change, it adds supports for +> multi-line result formats, and rendering big search buffers should be +> less quadratic (it might even be linear). Much of this derives from +> having a single object representation of a result (the JSON plist) and +> a simple method for rendering it to the buffer. + +Overall this series looks excellent. I have reviewed all the patches +except patch 4/7 (I will need to work out how macros work to review +that) and they seem fine modulo the small comments I have made. + +One final comment: I couldn't persuade the defcustom search result to +take a newline symbol to test multiline results. It seems to escape +entries of \n, and I couldn't enter returns (and ^Q return didn't work +either). + +It was easy by editing the option in my .emacs file and then seemed to +work as expected. + +Best wishes + +Mark +> +> [0] 1341870162-17782-1-git-send-email-amdragon@mit.edu +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch