From: David Bremner <bremner@debian.org>
Date: Sat, 4 Feb 2012 00:50:51 +0000 (+2000)
Subject: Re: [PATCH] STYLE: Initial draft of coding style document
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=c4bdfa410fbfcffe003abf5592d2b8c9510e4693;p=notmuch-archives.git

Re: [PATCH] STYLE: Initial draft of coding style document
---

diff --git a/34/03514781c036f8dcddc56baf04e0bc853ac420 b/34/03514781c036f8dcddc56baf04e0bc853ac420
new file mode 100644
index 000000000..27b1432c4
--- /dev/null
+++ b/34/03514781c036f8dcddc56baf04e0bc853ac420
@@ -0,0 +1,82 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id C4953431FAF
+	for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 21:20:19 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: -1.224
+X-Spam-Level: 
+X-Spam-Status: No, score=-1.224 tagged_above=-999 required=5
+	tests=[DATE_IN_PAST_03_06=1.076, RCVD_IN_DNSWL_MED=-2.3]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Zl+MHEr5h7zU for <notmuch@notmuchmail.org>;
+	Fri,  3 Feb 2012 21:20:17 -0800 (PST)
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
+	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id BC39D431FAE
+	for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 21:20:17 -0800 (PST)
+Received: from rocinante.cs.unb.ca ([209.104.169.194]) (authenticated bits=0)
+	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q145K5fb012702
+	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
+	Sat, 4 Feb 2012 01:20:08 -0400
+Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.77)
+	(envelope-from <bremner@unb.ca>)
+	id 1RtTq7-0002nA-CI; Fri, 03 Feb 2012 20:50:51 -0400
+From: David Bremner <bremner@debian.org>
+To: Jani Nikula <jani@nikula.org>, Tomi Ollila <tomi.ollila@iki.fi>
+Subject: Re: [PATCH] STYLE: Initial draft of coding style document
+In-Reply-To:
+ <CAB+hUn-o8JyWPqS+1e37m171cR04=LNOCBxFLyUiRK1vWjbe3g@mail.gmail.com>
+References: <1327708018-1107-1-git-send-email-david@tethera.net>
+	<m2ehuhdzls.fsf@guru.guru-group.fi>
+	<CAB+hUn-o8JyWPqS+1e37m171cR04=LNOCBxFLyUiRK1vWjbe3g@mail.gmail.com>
+User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 03 Feb 2012 20:50:51 -0400
+Message-ID: <87vcnnjuac.fsf@rocinante.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 04 Feb 2012 05:20:19 -0000
+
+On Mon, 30 Jan 2012 18:01:15 +0200, Jani Nikula <jani@nikula.org> wrote:
+> On Jan 30, 2012 4:38 PM, "Tomi Ollila" <tomi.ollila@iki.fi> wrote:
+> >
+> > > +
+> > > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8.
+> > > +  Tabs should be only at the beginning of the line.
+> >
+> > So, after initial indentation (with tabs) there should not be further
+> > tabs? We'll be using the former instead of the latter in these 2 below?
+
+Ah, I only meant to explain what whitespace-mode complains about, namely
+
+<space><space><space><space><tab>x=1;
+
+as opposed to 
+
+<tab<space><space><space><space><tab>x=1;
+
+I'm not sure it's that important, but apparently if it stays in the
+style guide it needs rewording.
+
+d
+
+