From: Zac Medico <zmedico@gentoo.org>
Date: Sat, 24 Sep 2011 22:03:07 +0000 (-0700)
Subject: portdbapi: deprecate unused 'visible' method
X-Git-Tag: v2.2.0_alpha60~16
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=c495b938fd10295928f455db6391bcdac2031acc;p=portage.git

portdbapi: deprecate unused 'visible' method
---

diff --git a/pym/portage/dbapi/porttree.py b/pym/portage/dbapi/porttree.py
index 62a1e8f55..9a8f50826 100644
--- a/pym/portage/dbapi/porttree.py
+++ b/pym/portage/dbapi/porttree.py
@@ -962,18 +962,17 @@ class portdbapi(dbapi):
 	def gvisible(self, mylist):
 		warnings.warn("The 'gvisible' method of "
 			"portage.dbapi.porttree.portdbapi "
-			"is deprecated, and the functionality "
-			"has been combined into the 'visible' method",
+			"is deprecated",
 			DeprecationWarning, stacklevel=2)
-		return self.visible(mylist)
+		return list(self._iter_visible(iter(mylist)))
 
 	def visible(self, cpv_iter):
-		"""
-		Return a list containing only visible packages.
-		"""
+		warnings.warn("The 'visible' method of "
+			"portage.dbapi.porttree.portdbapi "
+			"is deprecated",
+			DeprecationWarning, stacklevel=2)
 		if cpv_iter is None:
 			return []
-
 		return list(self._iter_visible(iter(cpv_iter)))
 
 	def _iter_visible(self, cpv_iter, myrepo=None):