From: Dmitry Kurochkin Date: Mon, 5 Mar 2012 15:42:12 +0000 (+0400) Subject: Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=c303eb6ea43f23d8f7522da79afb295b7f3dbd1d;p=notmuch-archives.git Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function --- diff --git a/87/fde0b8196e3b54e4eba5f27c9f3c74ef699d2c b/87/fde0b8196e3b54e4eba5f27c9f3c74ef699d2c new file mode 100644 index 000000000..4fa1c3719 --- /dev/null +++ b/87/fde0b8196e3b54e4eba5f27c9f3c74ef699d2c @@ -0,0 +1,125 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D9A1E431FBC + for ; Mon, 5 Mar 2012 07:43:44 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id F5g7lJ6HWL6V for ; + Mon, 5 Mar 2012 07:43:44 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1A93F431FAE + for ; Mon, 5 Mar 2012 07:43:43 -0800 (PST) +Received: by bkwj4 with SMTP id j4so3784591bkw.26 + for ; Mon, 05 Mar 2012 07:43:41 -0800 (PST) +Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com + designates 10.204.156.70 as permitted sender) + client-ip=10.204.156.70; +Authentication-Results: mr.google.com; spf=pass (google.com: domain of + dmitry.kurochkin@gmail.com designates 10.204.156.70 as + permitted sender) smtp.mail=dmitry.kurochkin@gmail.com; + dkim=pass header.i=dmitry.kurochkin@gmail.com +Received: from mr.google.com ([10.204.156.70]) + by 10.204.156.70 with SMTP id v6mr1449625bkw.124.1330962221503 + (num_hops = 1); Mon, 05 Mar 2012 07:43:41 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=2sUSidYx47yR3QYGrOCC1jvFwtvz0Jj0LM1iuFa4dKE=; + b=Z1eUK7+e3M80W5ZzkeYT/ty9mV+x16tB9wlNB80cJtj5k7kYxvOVQS9EBFLj+0EYpY + RVGbmLmzJPHrQrv/2jNl6PrjE2bBl/6vnDkXY4Me3VK/gez7zYB06aSRnaSJRYM/I6MN + 7r+Mvo/tC9ipBql+7Bx6phkh84F919rLauVCWkgwBmThNjRdbDOagp5HXHuEsj2Ik+hZ + +LCKYRrOA/id5m3SysbggsdV9cXX8d/srRz90dMgaw1rOIRHHBL37ZveAPHECSxWJoP3 + RzJTaGzN+boqnzoAi3k6g3jp0cNpWU2lN64sHI39+RMluuovRT0DCJVsv8racPn7hDut + S04g== +Received: by 10.204.156.70 with SMTP id v6mr1094790bkw.124.1330962221373; + Mon, 05 Mar 2012 07:43:41 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id d5sm26371937bkb.3.2012.03.05.07.43.39 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 05 Mar 2012 07:43:40 -0800 (PST) +From: Dmitry Kurochkin +To: Daniel Schoepe , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Pass a copy to + notmuch-saved-search-sort-function +In-Reply-To: <87399n2t60.fsf@schoepe.localhost> +References: <1330613059-5130-1-git-send-email-daniel@schoepe.org> + <1330633478-1974-1-git-send-email-daniel@schoepe.org> + <1330633478-1974-2-git-send-email-daniel@schoepe.org> + <87booblrcv.fsf@gmail.com> <87399n2t60.fsf@schoepe.localhost> +User-Agent: Notmuch/0.11.1+288~g4b3af0e (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 05 Mar 2012 19:42:12 +0400 +Message-ID: <878vjfkqaz.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 05 Mar 2012 15:43:45 -0000 + +On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: +> On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin wrote: +> > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: +> > > notmuch-saved-search-sort-function might destructively modify its +> > > input (`sort' does that, for instance), so it should not be given +> > > notmuch-saved-searches directly. +> > > --- +> > +> > -1 +> > +> > I think we should require `notmuch-saved-search-sort-function' not to +> > have side effects. Current documentation should be more clear about +> > this. We need to fix `notmuch-sort-saved-searches' to copy the list +> > before calling `sort'. But we should not do it in +> > `notmuch-hello-insert-saved-searches' for any sorting function (which +> > may not need this copying). +> +> My reasoning was that since sort is such a common function, many users +> will probably use sort for their own sorting functions, not realizing +> that it has side effects. This will lead to confusing behavior that's +> not so easy to track down. +> +> Copying the list of saved searches when running notmuch-hello does not +> seem be relevant to performance to me, since it's a) not called that +> often and b) the list of saved searches will rarely exceed 30 elements. +> +> Hence, this way we can avoid some headaches for users who define their +> own sorting functions at a negligible (performance) cost. Incidentally, +> this is also how notmuch-hello did it before the user-defined sections +> patches. +> + +I do not buy the argument that we should help users who implement their +own sorting functions but do not read documentation for functions they +use. Apparently, those who implemented the `sort' function had similar +ideas. And I do not think it is our job to add workarounds for it. + +An alternative (and IMO better) solution would be to allow customization +of compare function used for sorting instead of the sorting function +itself. + +Regards, + Dmitry + +> Cheers, +> Daniel