From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 10 Nov 2012 16:23:43 +0000 (+0200)
Subject: Re: [PATCH v2] contrib: pick: bugfix when trying to show a non-message
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=c11a5e26a2ddee6cc6b8b78ba93c0f52c1571aa3;p=notmuch-archives.git

Re: [PATCH v2] contrib: pick: bugfix when trying to show a non-message
---

diff --git a/98/66569c9c0f78f1b14cf157cfba606d219bcc16 b/98/66569c9c0f78f1b14cf157cfba606d219bcc16
new file mode 100644
index 000000000..2062f0758
--- /dev/null
+++ b/98/66569c9c0f78f1b14cf157cfba606d219bcc16
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 39E9B431FB6
+	for <notmuch@notmuchmail.org>; Sat, 10 Nov 2012 08:23:45 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id YJWXgOTmVhzl for <notmuch@notmuchmail.org>;
+	Sat, 10 Nov 2012 08:23:44 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 99787431FAF
+	for <notmuch@notmuchmail.org>; Sat, 10 Nov 2012 08:23:44 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 64EA5100094;
+	Sat, 10 Nov 2012 18:23:43 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2] contrib: pick: bugfix when trying to show a
+ non-message
+In-Reply-To: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>
+References: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 10 Nov 2012 18:23:43 +0200
+Message-ID: <m2y5i94eb4.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 10 Nov 2012 16:23:45 -0000
+
+On Sat, Nov 10 2012, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> If the user pressed return on the end result status line it gave a
+> blank message. Modify the function notmuch-pick-get-message-id to
+> return nil rather than an empty message-id in this case to fix this.
+>
+> This also fixes a bug in the (lack of) quoting of the id string.
+> ---
+
+LGTM
+
+Tomi
+
+> Version 1 is at
+> id:1351797983-19707-1-git-send-email-markwalters1009@gmail.com
+>
+> This version changes the `when' to and `if' and adds the fix for the
+> quoting.
+>
+> Best wishes
+>
+> Mark
+>
+>  contrib/notmuch-pick/notmuch-pick.el |    4 +++-
+>  1 files changed, 3 insertions(+), 1 deletions(-)
+>
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
+> index 15ac5e8..bbfa6fb 100644
+> --- a/contrib/notmuch-pick/notmuch-pick.el
+> +++ b/contrib/notmuch-pick/notmuch-pick.el
+> @@ -241,7 +241,9 @@ Some useful entries are:
+>  
+>  (defun notmuch-pick-get-message-id ()
+>    "Return the message id of the current message."
+> -  (concat "id:\"" (notmuch-pick-get-prop :id) "\""))
+> +  (let ((id (notmuch-pick-get-prop :id)))
+> +    (if id
+> +	(notmuch-id-to-query id))))
+>  
+>  (defun notmuch-pick-get-match ()
+>    "Return whether the current message is a match."
+> -- 
+> 1.7.9.1
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch