From: Austin Clements Date: Wed, 14 Mar 2012 02:08:24 +0000 (+2000) Subject: Re: [PATCH 0/2] A bug in the exclude code X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=bffc593f621379265f4f301354a9d8885c38fc37;p=notmuch-archives.git Re: [PATCH 0/2] A bug in the exclude code --- diff --git a/b8/1026d7e16a4412ba3bd65eb3ce6090125a1426 b/b8/1026d7e16a4412ba3bd65eb3ce6090125a1426 new file mode 100644 index 000000000..16c16fd0a --- /dev/null +++ b/b8/1026d7e16a4412ba3bd65eb3ce6090125a1426 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D9F94431FAF + for ; Tue, 13 Mar 2012 19:08:27 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3aX30kmmW5Hj for ; + Tue, 13 Mar 2012 19:08:27 -0700 (PDT) +Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU + [18.9.25.14]) + by olra.theworths.org (Postfix) with ESMTP id 5D26C431FAE + for ; Tue, 13 Mar 2012 19:08:27 -0700 (PDT) +X-AuditID: 1209190e-b7f7c6d0000008c3-f2-4f5ffd9aa935 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP + id 11.A1.02243.A9DFF5F4; Tue, 13 Mar 2012 22:08:26 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q2E28PAX004993; + Tue, 13 Mar 2012 22:08:26 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2E28OXp019206 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Tue, 13 Mar 2012 22:08:25 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1S7ddY-0005nx-3l; Tue, 13 Mar 2012 22:08:24 -0400 +From: Austin Clements +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/2] A bug in the exclude code +In-Reply-To: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com> +References: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.11.1+252~gdf1a6d5 (http://notmuchmail.org) Emacs/23.3.1 + (i486-pc-linux-gnu) +Date: Tue, 13 Mar 2012 22:08:24 -0400 +Message-ID: <87mx7kndd3.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsUixCmqrDvrb7y/weo+LYvVc3ksrt+cyezA + 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZXz/9IOxYCZXxbmG1ywNjH/Yuxg5OSQETCSe + nmtmhrDFJC7cW8/WxcjFISSwj1Hi8KU1jBDOBkaJz4fWsUI4J5kkjm9dDZVZwijx48RnVpB+ + NgENiW37lzOC2CICrhJPv30GmyssYCRx5tMPsH2cAl4Saz68ArOFBDwlevZ+YAGxRQUSJdZ3 + 3mcCsVkEVCW+bz8JFOfg4AW6r+d6NEiYV0BQ4uTMJ2DlzAJaEjf+vWSawCgwC0lqFpLUAkam + VYyyKblVurmJmTnFqcm6xcmJeXmpRbrGermZJXqpKaWbGMEBKcm3g/HrQaVDjAIcjEo8vMK1 + 8f5CrIllxZW5hxglOZiURHkj3wKF+JLyUyozEosz4otKc1KLDzFKcDArifC+mAqU401JrKxK + LcqHSUlzsCiJ86ppvfMTEkhPLEnNTk0tSC2CycpwcChJ8KqADBUsSk1PrUjLzClBSDNxcIIM + 5wEaXv4dZHhxQWJucWY6RP4Uo6KUOO+dN0AJAZBERmkeXC8sYbxiFAd6RZh3JUgVDzDZwHW/ + AhrMBDS45FscyOCSRISUVANjPMt1tlXv72TtOpfmnZu7XvuGgV935m1fJjHezX9idkXdKlk4 + U2d/WF61mvmqOdedGVmzXr+Z5bd4X27tc7erLwu25e85FFO8znhJp33CnB/aawLW75Dr39zx + vpSl/UjJxLsXZ0sGbN+9bbFM49YlSk3v8u982m24OfS6lNJJ625ZC+8Ve5wmKbEUZyQaajEX + FScCAEt4Sm3zAgAA +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 14 Mar 2012 02:08:28 -0000 + +On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters wrote: +> There is a bug in the exclude code (found by jrollins in the +> --with-excluded series) but also present in master. None of the +> current tests were finding it so the first patch adds two tests. +> +> The bug (and test failure) do not appear in all configuations: on my +> main test machine (an oldish debian testing 32bit userspace with a +> 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent +> debian testing 64bit userspace and xapian 1.2.8) one of the new tests +> fails. +> +> The second patch fixes the behaviour for me but I don't see why it +> should make a difference: searches for A and not B should give the +> same results as A and not (A and B). It could be a bug in xapian, it +> could be that I am not allowed to reuse queries as I do (is query1 = +> query1 and query2 allowed?) or it could be some memory use bug on my +> part. +> +> Anyway the "fix" is small which should help narrow down the actual +> cause. + +LGTM. Even if we don't totally understand the root cause here, this +change is the right thing to do anyway. + +I think it's fine to go ahead and push this ahead of the other exclude +updates, though obviously those will need a little rebasing on top of +this.