From: Tomi Ollila Date: Mon, 30 Jan 2012 08:23:31 +0000 (+0200) Subject: Re: [PATCH 2/2] emacs: Quote MML tags in replies X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=bed792eb20fe2206ea52a0db8197e54c85ea3a4c;p=notmuch-archives.git Re: [PATCH 2/2] emacs: Quote MML tags in replies --- diff --git a/51/0d123d06b2ca2b4bbd6e5a97fb6395e5cb2c24 b/51/0d123d06b2ca2b4bbd6e5a97fb6395e5cb2c24 new file mode 100644 index 000000000..8a201b6f9 --- /dev/null +++ b/51/0d123d06b2ca2b4bbd6e5a97fb6395e5cb2c24 @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5B09C431E64 + for ; Mon, 30 Jan 2012 00:23:29 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AOPTxbhJgBQv for ; + Mon, 30 Jan 2012 00:23:29 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id E345B431FBC + for ; Mon, 30 Jan 2012 00:23:28 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 3ADD068056; Mon, 30 Jan 2012 10:23:31 +0200 (EET) +From: Tomi Ollila +To: Aaron Ecay , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] emacs: Quote MML tags in replies +In-Reply-To: <1327817229-18124-2-git-send-email-aaronecay@gmail.com> +References: <20120126191654.GF1940@mit.edu> + <1327817229-18124-1-git-send-email-aaronecay@gmail.com> + <1327817229-18124-2-git-send-email-aaronecay@gmail.com> +User-Agent: Notmuch/0.11+116~g34d80c9 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 08:23:29 -0000 + +On Sun, 29 Jan 2012 01:07:08 -0500, Aaron Ecay wrote: +> Emacs message-mode uses certain text strings to indicate how to attach +> files to outgoing mail. If these are present in the text of an email, +> and a user is tricked into replying to the message, the user=E2=80=99s fi= +les +> could be exposed. +> --- + +[ ... ] + +>=20=20 +> - (message-goto-body)) +> + (message-goto-body) +> + (mml-quote-region (point) (mark))) + +As asked before, comment why mmm-quote-region is needed=20 +and why (mark) is used instead of (point-max) is there. +We know the reasons but future viewers of the code will +wonder a while... + +Tomi