From: Mark Walters Date: Mon, 3 Dec 2012 22:45:22 +0000 (+0000) Subject: Re: [PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=b9be9ef3ab0ed57f660bdb65e04d81d59ca30d0a;p=notmuch-archives.git Re: [PATCH v2 0/3] Allow emacs to toggle display of all parts including multipart --- diff --git a/56/ee6bc41f32e2259c3df60854c8a082364c2a35 b/56/ee6bc41f32e2259c3df60854c8a082364c2a35 new file mode 100644 index 000000000..a8ffa7429 --- /dev/null +++ b/56/ee6bc41f32e2259c3df60854c8a082364c2a35 @@ -0,0 +1,126 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 21279431FBC + for ; Mon, 3 Dec 2012 14:45:32 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id d8fBa0nVKZdi for ; + Mon, 3 Dec 2012 14:45:31 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 80A54431FAE + for ; Mon, 3 Dec 2012 14:45:31 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1TfelL-0000kO-Tc; Mon, 03 Dec 2012 22:45:20 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1TfelL-0004ky-Ki; Mon, 03 Dec 2012 22:45:19 +0000 +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/3] Allow emacs to toggle display of all parts + including multipart +In-Reply-To: <1354496317-24564-1-git-send-email-markwalters1009@gmail.com> +References: <1354496317-24564-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Mon, 03 Dec 2012 22:45:22 +0000 +Message-ID: <87zk1uvjp9.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 47c21428a9b3ed77dfb2c7d06e543307 (of first 20000 bytes) +X-SpamAssassin-Score: -1.1 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.1 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * 0.2 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 03 Dec 2012 22:45:32 -0000 + + +Hi + +I now have a version which does this `right': using invisibility as with +citations and signatures etc. It is working but I need to look through +more carefully before posting. + +Best wishes + +Mark + +On Mon, 03 Dec 2012, Mark Walters wrote: +> This is rather more polished version of +> id:1351152563-27277-1-git-send-email-markwalters1009@gmail.com. +> +> The first patch modifies the behaviour of show refresh buffer to keep +> state more accurately where possible. It can never be perfect but it +> makes a reasonable attempt. This is independent of patches 2 and 3. +> +> The second patch allows the user to toggle the visibility of any part +> with 't' on the part button. It does this by storing a list of all +> parts that the user has over-ruled. +> +> The final patch binds the toggle to the default action in cases where +> the part has no filename. Is this a reasonable heuristic? And should +> it be customisable? In all cases the defined actions (save, view, +> other, and toggle) always do their action (ie they do not apply any +> heuristics) +> +> Overall I am pleased with the way it works. The one caveat is that it +> does redisplay the whole buffer when toggling the parts: it might be +> nice to use invisibility but that is beyond my lisp. Moreover it could +> be added at a later stage without changing the user experience. +> +> +> Best wishes +> +> Mark +> +> +> Mark Walters (3): +> emacs: show: make refresh fix point(ish) +> emacs: allow the user to toggle the visibility of +> multipart/alternative parts +> emacs: show make default part button toggle view when sensible +> +> emacs/notmuch-show.el | 80 ++++++++++++++++++++++++++++++++++++++---------- +> 1 files changed, 63 insertions(+), 17 deletions(-) +> +> -- +> 1.7.9.1