From: Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr>
Date: Tue, 13 Nov 2012 07:46:18 +0000 (+0000)
Subject: Re: [PATCH v2] contrib: pick: bugfix when trying to show a non-message
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=b8253cbc9620d7bbb30df8e50b2d9874724eacb8;p=notmuch-archives.git

Re: [PATCH v2] contrib: pick: bugfix when trying to show a non-message
---

diff --git a/72/ea2d962f50463bdcaa4d279cb8e88abd079913 b/72/ea2d962f50463bdcaa4d279cb8e88abd079913
new file mode 100644
index 000000000..1aafec27d
--- /dev/null
+++ b/72/ea2d962f50463bdcaa4d279cb8e88abd079913
@@ -0,0 +1,78 @@
+Return-Path: <kimminh.kaplan+nomuch@afnic.fr>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 323C1431FBC
+	for <notmuch@notmuchmail.org>; Mon, 12 Nov 2012 23:46:53 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Yo8eos0ID-Zt for <notmuch@notmuchmail.org>;
+	Mon, 12 Nov 2012 23:46:52 -0800 (PST)
+Received: from mx4.nic.fr (mx4.nic.fr [192.134.4.12])
+	by olra.theworths.org (Postfix) with ESMTP id 6EAE1431FAF
+	for <notmuch@notmuchmail.org>; Mon, 12 Nov 2012 23:46:52 -0800 (PST)
+Received: from mx4.nic.fr (localhost [127.0.0.1])
+	by mx4.nic.fr (Postfix) with SMTP id B38A82802BD;
+	Tue, 13 Nov 2012 08:46:48 +0100 (CET)
+Received: from relay2.nic.fr (relay2.nic.fr [192.134.4.163])
+	by mx4.nic.fr (Postfix) with ESMTP id AE9FA280136;
+	Tue, 13 Nov 2012 08:46:48 +0100 (CET)
+Received: from kaki.tech.prive.nic.fr (kaki.tech.prive.sqy.nic.fr
+	[10.10.86.114]) by relay2.nic.fr (Postfix) with ESMTP id AD28CB38004;
+	Tue, 13 Nov 2012 08:46:18 +0100 (CET)
+Received: by kaki.tech.prive.nic.fr (Postfix, from userid 1000)
+	id 860DC3F8225; Tue, 13 Nov 2012 07:46:18 +0000 (UTC)
+From: Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr>
+To: Mark Walters <markwalters1009@gmail.com>
+Subject: Re: [PATCH v2] contrib: pick: bugfix when trying to show a
+ non-message
+References: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>
+Date: Tue, 13 Nov 2012 07:46:18 +0000
+In-Reply-To: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>
+	(Mark Walters's message of "Sat, 10 Nov 2012 15:45:50 +0000")
+Message-ID: <87haou54j9.fsf@kaki.tech.prive.nic.fr>
+User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 13 Nov 2012 07:46:53 -0000
+
+Mark Walters writes:
+
+David Bremner writes:
+
+> Mark Walters <markwalters1009@gmail.com> writes:
+>
+>> This version changes the `when' to and `if' and adds the fix for the
+>> quoting.
+>>
+>> +    (if id
+>> +      (notmuch-id-to-query id))
+
+> Sorry to be such a pedant about this. Is it obvious to other people that 
+> (if nil 'something) evaluates to nil?
+
+The obvious would be:
+
+    (and id
+         (notmuch-id-to-query id))
+
+Kim Minh.