From: Jameson Graef Rollins Date: Mon, 26 Mar 2012 15:14:33 +0000 (+1700) Subject: Re: [PATCH v2 1/3] cli: refactor "notmuch tag" data structures for tagging operations X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=b822651310d5ffc42fc85938ace809b4ed5501a7;p=notmuch-archives.git Re: [PATCH v2 1/3] cli: refactor "notmuch tag" data structures for tagging operations --- diff --git a/cf/2e18d9f48300ce523d688c69b4d4de1e511132 b/cf/2e18d9f48300ce523d688c69b4d4de1e511132 new file mode 100644 index 000000000..554e50bc0 --- /dev/null +++ b/cf/2e18d9f48300ce523d688c69b4d4de1e511132 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C944F431FAF + for ; Mon, 26 Mar 2012 08:14:46 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id H1D9Yy6JYpWV for ; + Mon, 26 Mar 2012 08:14:44 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 4B6BB431FAE + for ; Mon, 26 Mar 2012 08:14:44 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id DF01066E0131; + Mon, 26 Mar 2012 08:14:43 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (pool-108-27-62-184.nycmny.fios.verizon.net + [108.27.62.184]) (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 17F0D66E012B; + Mon, 26 Mar 2012 08:14:38 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 63951573; Mon, 26 Mar 2012 08:14:36 -0700 (PDT) +From: Jameson Graef Rollins +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 1/3] cli: refactor "notmuch tag" data structures for + tagging operations +In-Reply-To: + <0862d8a5424d6d0da188db84340b027fdede4245.1332702915.git.jani@nikula.org> +References: + <0862d8a5424d6d0da188db84340b027fdede4245.1332702915.git.jani@nikula.org> +User-Agent: Notmuch/0.11.1+335~gf868783 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 26 Mar 2012 08:14:33 -0700 +Message-ID: <878vinl7hi.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 26 Mar 2012 15:14:46 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +On Sun, 25 Mar 2012 22:18:43 +0300, Jani Nikula wrote: +> To simplify code, keep all tagging operations in a single array +> instead of separate add and remove arrays. Apply tag changes in the +> order specified on the command line, instead of first removing and +> then adding the tags. +>=20 +> This results in a minor functional change: If a tag is both added and +> removed, the last specified operation is now used. Previously the tag +> was always added. + +If this changes the behavior of notmuch then I think there should be a +test for it. We should probably see a test for the current behavior, +and a modification of it to reflect whatever behavior is changing. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBCAAGBQJPcIfaAAoJEO00zqvie6q8DUoP/i09AJTQPYa85aSwIJs0vHbv +KSzDyzVrHGq6rsr46UraziOFKZEJ+Gv+IFY2Ah70qsuU+1SG+I2zmwUhGgwM1whq +KqIeBjfNbOOYt4A8r78qic3GdFSpex9WG5Yacb6Svud5ZA9oWcdk+6aGMSvihWDo +jdz1ItDWZpBCHPeouaIqley2kgxgOKVY2Nb0TyUfpyFBjN63GN5rFaBwAnalB9d4 +DvMwqfrc3+AjGlm0jcpSNcZ7Li9419kvBIQ1pRCk/rA1jzhkCEZsRBofnYMEuKH8 +pEXZw+Ur7wLSaiaChGKUrJXDa7KIdV+UR0jBrgjs763a3y6F9mH3So4sad1bQKCn +8xT6iObYTA/PUevUpJw0AHRViOGVZIUvgF6ydGQT6RyYerjlW+lBMGUb8bSBtHFP +bpKan2tu6s2E5TPksbC4UxXfB0E5uo1o4M5barsLRNYDu3Ws1i3Z6sFnxbge56fE +0SxDHriTAhjejtcecEOr2gd8066LpkQBZZVy0/l5fTvJnmw94+djYqy1XjZilbXP +tJ4NmQDvSeM6w/daQBGGx2s1F2v59j4/nOxzjM7P+DrvW9PzPfDrUjPEvlcOKjDA +IaDxFfelfmK6M+nQ9bNxJEiCZsmHSjSxRK4XWzx2T8p+fS8nO2YFI4u0OOsQEQwv +heb48oqFSMS6pcZF/zvY +=ecVs +-----END PGP SIGNATURE----- +--=-=-=--