From: Tomi Ollila Date: Wed, 31 Oct 2012 11:35:29 +0000 (+0200) Subject: Re: [PATCH v6 0/9] notmuch search date:since..until query support X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=b80d2f408332f225f5db27739159173c773668ca;p=notmuch-archives.git Re: [PATCH v6 0/9] notmuch search date:since..until query support --- diff --git a/ea/ff574c331e65b88a963ec91990ddd57cc1418f b/ea/ff574c331e65b88a963ec91990ddd57cc1418f new file mode 100644 index 000000000..2451f7585 --- /dev/null +++ b/ea/ff574c331e65b88a963ec91990ddd57cc1418f @@ -0,0 +1,136 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4C611431FBD + for ; Wed, 31 Oct 2012 04:35:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ku5pEWhvnT4h for ; + Wed, 31 Oct 2012 04:35:30 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id ECA60431FBC + for ; Wed, 31 Oct 2012 04:35:29 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id CFB2E10007D; + Wed, 31 Oct 2012 13:35:29 +0200 (EET) +From: Tomi Ollila +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v6 0/9] notmuch search date:since..until query support +In-Reply-To: +References: +User-Agent: Notmuch/0.14+59~gf9031cd (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 31 Oct 2012 11:35:31 -0000 + +On Tue, Oct 30 2012, Jani Nikula wrote: + +> Hi all, v6 of [1] with plenty of small changes addressing Austin's +> review [2], [3], [4], and [5]. See my replies to Austin for what I've +> agreed to change, and what I've chosen to ignore and why. +> +> The single biggest change is the requirement to have some delimiter(s) +> between keywords, which allowed simplification of keyword +> matching. Consequently match_keyword() and parse_keyword() functions in +> patch 2/9 have changed considerably. +> +> There are a few ways to examine the changes since v5. My public repo at +> [6] has branches topic-parse-time-string-v5 (rebased to master) and +> topic-parse-time-string-v6, and [7] should provide a fancy colorful diff +> between the two. The same but less fancy diff is also at the end of this +> cover letter. +> +> Change by change commits to the parser and test tool can also be found +> at [8]. The source files there are copied verbatim to patches 2/9 and +> 3/9. + +LGTM + +> +> BR, +> Jani. +> + +Tomi + +> [1] id:cover.1350854171.git.jani@nikula.org +> [2] id:20121022081444.GM14861@mit.edu for patch 2/9 +> [3] id:20121023042326.GP14861@mit.edu for patch 4/9 +> [4] id:20121023045255.GQ14861@mit.edu for patch 6/9 +> [5] id:20121024210841.GU14861@mit.edu for patch 8/9 +> [6] https://gitorious.org/jani/notmuch +> [7] https://gitorious.org/jani/notmuch/commit/06c76eb4181bc88eccabc419c690046682125d7a/diffs/ef5e8d111748784433f4b80c9e5378f0c1a57319 +> [8] https://gitorious.org/parse-time-string/parse-time-string +> +> Jani Nikula (9): +> build: drop the -Wswitch-enum warning +> parse-time-string: add a date/time parser to notmuch +> test: add new test tool parse-time for date/time parser +> test: add smoke tests for the date/time parser module +> build: build parse-time-string as part of the notmuch lib and static +> cli +> lib: add date range query support +> test: add tests for date:since..until range queries +> man: document the date:since..until range queries +> NEWS: date range search support +> +> Makefile | 2 +- +> Makefile.local | 2 +- +> NEWS | 12 + +> configure | 2 +- +> lib/Makefile.local | 3 +- +> lib/database-private.h | 1 + +> lib/database.cc | 5 + +> lib/parse-time-vrp.cc | 61 ++ +> lib/parse-time-vrp.h | 40 + +> man/man7/notmuch-search-terms.7 | 150 +++- +> parse-time-string/Makefile | 5 + +> parse-time-string/Makefile.local | 12 + +> parse-time-string/README | 9 + +> parse-time-string/parse-time-string.c | 1503 +++++++++++++++++++++++++++++++++ +> parse-time-string/parse-time-string.h | 102 +++ +> test/Makefile.local | 7 +- +> test/basic | 2 +- +> test/notmuch-test | 2 + +> test/parse-time-string | 78 ++ +> test/parse-time.c | 314 +++++++ +> test/search-date | 21 + +> 21 files changed, 2315 insertions(+), 18 deletions(-) +> create mode 100644 lib/parse-time-vrp.cc +> create mode 100644 lib/parse-time-vrp.h +> create mode 100644 parse-time-string/Makefile +> create mode 100644 parse-time-string/Makefile.local +> create mode 100644 parse-time-string/README +> create mode 100644 parse-time-string/parse-time-string.c +> create mode 100644 parse-time-string/parse-time-string.h +> create mode 100755 test/parse-time-string +> create mode 100644 test/parse-time.c +> create mode 100755 test/search-date +> +> -- +> 1.7.10.4